fix: remove PR comment code, add log_url to approval checks

- Remove FindPullRequestForBranch, CreateIssueComment, UpdateIssueComment,
  FindBotComment from GitHub client interface and implementations
- Delete github_comment.go (PR comment reporter)
- Remove all updatePRComment calls from deploy_handler.go
- Add log_url to pending GitHub deployment status in approval flow so
  clicking the check on GitHub links to the dashboard approval page
- Fix exhaustruct lint for seed/harness test files

Author: Flo4604

svc/ctrl/integration/harness/harness.go

@@ -173,6 +173,7 @@ func New(t *testing.T) *Harness {
 		DB:            database,
 		Clickhouse:    chClient,
 		DefaultDomain: "test.example.com",
+		DashboardURL:  "https://app.unkey.com",
 		Vault:         vaultClient,
 		SentinelImage: "test-sentinel:latest",
 

svc/ctrl/integration/seed/seed.go

@@ -146,15 +146,16 @@ func (h *Seeder) CreateProject(ctx context.Context, req CreateProjectRequest) db
 	require.NoError(h.t, err)
 
 	return db.Project{
-		ID:               project.ID,
-		WorkspaceID:      project.WorkspaceID,
-		Name:             project.Name,
-		Slug:             project.Slug,
-		DeleteProtection: project.DeleteProtection,
-		CreatedAt:        project.CreatedAt,
-		UpdatedAt:        project.UpdatedAt,
-		Pk:               0,
-		DepotProjectID:   sql.NullString{String: "", Valid: false},
+		ID:                   project.ID,
+		WorkspaceID:          project.WorkspaceID,
+		Name:                 project.Name,
+		Slug:                 project.Slug,
+		DeleteProtection:     project.DeleteProtection,
+		DeploymentProtection: project.DeploymentProtection,
+		CreatedAt:            project.CreatedAt,
+		UpdatedAt:            project.UpdatedAt,
+		Pk:                   0,
+		DepotProjectID:       sql.NullString{String: "", Valid: false},
 	}
 }
 

svc/ctrl/worker/deploy/BUILD.bazel

@@ -10,7 +10,6 @@ go_library(
         "deployment_step.go",
         "doc.go",
         "domains.go",
-        "github_comment.go",
         "github_status.go",
         "promote_handler.go",
         "rollback_handler.go",

svc/ctrl/worker/deploy/deploy_handler.go

@@ -178,35 +178,7 @@ func (w *Workflow) Deploy(ctx restate.ObjectContext, req *hydrav1.DeployRequest)
 	// --- GitHub Deployment Status ---
 	// Look up repo connection to determine if we should report to GitHub.
 	// Uses the interface so the noop is free — no nil checks needed.
-	ghResult := w.createStatusReporter(ctx, deployment, project, app, environment, workspace)
-	statusReporter := ghResult.reporter
-	repoConn := ghResult.repoConn
-	envURL := ghResult.environmentURL
-
-	// --- PR Comment ---
-	// Post/update a Vercel-style deployment comment on the PR with status and preview URL.
-	var prComment *prCommentReporter
-	if ghResult.hasRepoConn && deployment.GitBranch.Valid {
-
-		prComment = newPRCommentReporter(ctx, w.github, repoConn.InstallationID, repoConn.RepositoryFullName, deployment.GitBranch.String)
-		prComment.Update(ctx, []deploymentCommentRow{{
-			Environment: environment.Slug,
-			Status:      "🔨 Building",
-			PreviewURL:  envURL,
-			UpdatedAt:   time.Now(),
-		}})
-	}
-
-	updatePRComment := func(status string) {
-		if prComment != nil {
-			prComment.Update(ctx, []deploymentCommentRow{{
-				Environment: environment.Slug,
-				Status:      status,
-				PreviewURL:  envURL,
-				UpdatedAt:   time.Now(),
-			}})
-		}
-	}
+	statusReporter := w.createStatusReporter(ctx, deployment, project, app, environment, workspace).reporter
 
 	statusReporter.Report(ctx, "in_progress", "Building container image...")
 
@@ -216,12 +188,10 @@ func (w *Workflow) Deploy(ctx restate.ObjectContext, req *hydrav1.DeployRequest)
 	})
 	if err != nil {
 		statusReporter.Report(ctx, "failure", "Build failed")
-		updatePRComment("❌ Failed (Build)")
 		return nil, err
 	}
 
 	statusReporter.Report(ctx, "in_progress", "Deploying to regions...")
-	updatePRComment("🚀 Deploying")
 
 	// --- Deploy ---
 	err = w.DeploymentStep(ctx, db.DeploymentStepsStepDeploying, deployment, func(stepCtx restate.ObjectContext) error {
@@ -247,7 +217,6 @@ func (w *Workflow) Deploy(ctx restate.ObjectContext, req *hydrav1.DeployRequest)
 
 	if err != nil {
 		statusReporter.Report(ctx, "failure", "Deployment to regions failed")
-		updatePRComment("❌ Failed (Deploy)")
 		return nil, err
 	}
 
@@ -260,7 +229,6 @@ func (w *Workflow) Deploy(ctx restate.ObjectContext, req *hydrav1.DeployRequest)
 	})
 	if err != nil {
 		statusReporter.Report(ctx, "failure", "Routing configuration failed")
-		updatePRComment("❌ Failed (Routing)")
 		return nil, err
 	}
 
@@ -284,12 +252,10 @@ func (w *Workflow) Deploy(ctx restate.ObjectContext, req *hydrav1.DeployRequest)
 	})
 	if err != nil {
 		statusReporter.Report(ctx, "failure", "Finalization failed")
-		updatePRComment("❌ Failed (Finalize)")
 		return nil, err
 	}
 
 	statusReporter.Report(ctx, "success", "Deployment is live")
-	updatePRComment("✅ Ready")
 
 	logger.Info("deployment workflow completed",
 		"deployment_id", deployment.ID,

svc/ctrl/worker/deploy/github_comment.go

@@ -365,97 +365,3 @@ func (c *Client) IsCollaborator(installationID int64, repo string, username stri
 	return value, nil
 }
 
-// FindPullRequestForBranch finds an open pull request for the given branch.
-// Returns the PR number, or 0 if no open PR exists.
-func (c *Client) FindPullRequestForBranch(installationID int64, repo string, branch string) (int, error) {
-	headers, err := c.ghHeaders(installationID)
-	if err != nil {
-		return 0, err
-	}
-
-	parts := strings.SplitN(repo, "/", 2)
-	if len(parts) != 2 {
-		return 0, fault.New("invalid repo format, expected owner/repo")
-	}
-	owner := parts[0]
-
-	apiURL := fmt.Sprintf("https://api.github.com/repos/%s/pulls?head=%s:%s&state=open&per_page=1",
-		repo, url.QueryEscape(owner), url.QueryEscape(branch))
-
-	type ghPR struct {
-		Number int `json:"number"`
-	}
-
-	prs, err := httpclient.Request[[]ghPR](c.httpClient, http.MethodGet, apiURL, headers, nil, http.StatusOK)
-	if err != nil {
-		return 0, err
-	}
-
-	if len(prs) == 0 {
-		return 0, nil
-	}
-
-	return prs[0].Number, nil
-}
-
-// CreateIssueComment posts a comment on a GitHub issue or pull request.
-func (c *Client) CreateIssueComment(installationID int64, repo string, issueNumber int, body string) error {
-	headers, err := c.ghHeaders(installationID)
-	if err != nil {
-		return err
-	}
-
-	apiURL := fmt.Sprintf("https://api.github.com/repos/%s/issues/%d/comments", repo, issueNumber)
-
-	return httpclient.Do(c.httpClient, http.MethodPost, apiURL, headers, map[string]string{"body": body}, http.StatusCreated)
-}
-
-// UpdateIssueComment updates an existing comment on a GitHub issue or PR.
-func (c *Client) UpdateIssueComment(installationID int64, repo string, commentID int64, body string) error {
-	headers, err := c.ghHeaders(installationID)
-	if err != nil {
-		return err
-	}
-
-	apiURL := fmt.Sprintf("https://api.github.com/repos/%s/issues/comments/%d", repo, commentID)
-
-	return httpclient.Do(c.httpClient, http.MethodPatch, apiURL, headers, map[string]string{"body": body}, http.StatusOK)
-}
-
-// FindBotComment searches for a comment on a PR that contains the given marker
-// string. Returns the comment ID if found, or 0 if no matching comment exists.
-// Paginates through all comments to find it.
-func (c *Client) FindBotComment(installationID int64, repo string, issueNumber int, marker string) (int64, error) {
-	headers, err := c.ghHeaders(installationID)
-	if err != nil {
-		return 0, err
-	}
-
-	type ghComment struct {
-		ID   int64  `json:"id"`
-		Body string `json:"body"`
-	}
-
-	page := 1
-	for {
-		apiURL := fmt.Sprintf("https://api.github.com/repos/%s/issues/%d/comments?per_page=100&page=%d", repo, issueNumber, page)
-
-		comments, reqErr := httpclient.Request[[]ghComment](c.httpClient, http.MethodGet, apiURL, headers, nil, http.StatusOK)
-		if reqErr != nil {
-			return 0, reqErr
-		}
-
-		for _, comment := range comments {
-			if strings.Contains(comment.Body, marker) {
-				return comment.ID, nil
-			}
-		}
-
-		if len(comments) < 100 {
-			break
-		}
-		page++
-	}
-
-	return 0, nil
-}

svc/ctrl/worker/github/client.go

@@ -27,19 +27,6 @@ type GitHubClient interface {
 	// IsCollaborator checks whether a GitHub user is a collaborator on a repository.
 	IsCollaborator(installationID int64, repo string, username string) (bool, error)
 
-	// FindPullRequestForBranch finds an open pull request for the given branch.
-	// Returns the PR number, or 0 if no open PR exists.
-	FindPullRequestForBranch(installationID int64, repo string, branch string) (int, error)
-
-	// CreateIssueComment posts a comment on a GitHub issue or pull request.
-	CreateIssueComment(installationID int64, repo string, issueNumber int, body string) error
-
-	// UpdateIssueComment updates an existing comment on a GitHub issue or PR.
-	UpdateIssueComment(installationID int64, repo string, commentID int64, body string) error
-
-	// FindBotComment searches for a comment on a PR that contains the given marker string.
-	// Returns the comment ID if found, or 0 if no matching comment exists.
-	FindBotComment(installationID int64, repo string, issueNumber int, marker string) (int64, error)
 }
 
 // CommitInfo holds metadata about a single Git commit retrieved from the GitHub API.

svc/ctrl/worker/github/interface.go

@@ -49,26 +49,6 @@ func (n *Noop) IsCollaborator(_ int64, _ string, _ string) (bool, error) {
 	return false, errNotConfigured
 }
 
-// FindPullRequestForBranch returns an error indicating GitHub is not configured.
-func (n *Noop) FindPullRequestForBranch(_ int64, _ string, _ string) (int, error) {
-	return 0, errNotConfigured
-}
-
-// CreateIssueComment returns an error indicating GitHub is not configured.
-func (n *Noop) CreateIssueComment(_ int64, _ string, _ int, _ string) error {
-	return errNotConfigured
-}
-
-// UpdateIssueComment returns an error indicating GitHub is not configured.
-func (n *Noop) UpdateIssueComment(_ int64, _ string, _ int64, _ string) error {
-	return errNotConfigured
-}
-
-// FindBotComment returns an error indicating GitHub is not configured.
-func (n *Noop) FindBotComment(_ int64, _ string, _ int, _ string) (int64, error) {
-	return 0, errNotConfigured
-}
-
 // GetBranchHeadCommitPublic retrieves the HEAD commit using the public GitHub
 // API without authentication. Works for public repositories even when GitHub
 // App credentials are not configured.