fix: remove stale approval/rejected statuses, extract shared ctrl client

- Remove awaiting_approval and rejected from deployment statuses, filters,
  and status badge configs (no longer used — authorization is handled via
  GitHub Check Runs, not deployment status)
- Remove deployment.approve and deployment.reject audit log events
- Delete unused duplicate deployment-status-badge.tsx in table components
- Fix broken page.tsx referencing undefined awaitingApproval/rejected vars
- Extract createCtrlClient helper to deduplicate identical ctrl client
  creation boilerplate across 9 trpc router files

Author: Flo4604

web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/page.tsx

@@ -36,15 +36,7 @@ export default function DeploymentOverview() {
   return (
     <ProjectContentWrapper centered>
       <DeploymentInfo statusOverride={derivedStatus} />
-      {awaitingApproval ? (
-        <div key="awaiting-approval" className="animate-fade-slide-in">
-          <DeploymentApprovalBanner />
-        </div>
-      ) : rejected ? (
-        <div key="rejected" className="animate-fade-slide-in">
-          <DeploymentRejectedBanner />
-        </div>
-      ) : ready ? (
+      {ready ? (
         <div key="ready" className="flex flex-col gap-5 animate-fade-slide-in">
           <DeploymentDomainsCard />
           <DeploymentNetworkSection />

web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/components/table/components/deployment-status-badge.tsx

@@ -10,12 +10,10 @@ import { z } from "zod";
 
 // Define grouped statuses for client filtering
 const GROUPED_DEPLOYMENT_STATUSES = [
-  "awaiting_approval",
   "pending",
   "deploying", // represents all deploying states
   "ready",
   "failed",
-  "rejected",
 ] as const;
 
 const DEPLOYMENT_ENVIRONMENTS = ["production", "preview"] as const;
@@ -46,7 +44,7 @@ export const deploymentListFilterFieldConfig: FilterFieldConfigs = {
       if (value === "completed") {
         return "bg-success-9";
       }
-      if (value === "failed" || value === "rejected") {
+      if (value === "failed") {
         return "bg-error-9";
       }
       if (value === "pending") {
@@ -81,8 +79,6 @@ export const deploymentListFilterFieldConfig: FilterFieldConfigs = {
 // Mapping function to expand grouped statuses to actual statuses
 export const expandGroupedStatus = (groupedStatus: GroupedDeploymentStatus): DeploymentStatus[] => {
   switch (groupedStatus) {
-    case "awaiting_approval":
-      return ["awaiting_approval"];
     case "pending":
       return ["pending"];
     case "deploying":
@@ -91,8 +87,6 @@ export const expandGroupedStatus = (groupedStatus: GroupedDeploymentStatus): Dep
       return ["ready"];
     case "failed":
       return ["failed"];
-    case "rejected":
-      return ["rejected"];
     default:
       throw new Error(`Unknown grouped status: ${groupedStatus}`);
   }

web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/filters.schema.ts

@@ -24,13 +24,6 @@ type StatusConfig = {
 };
 
 const statusConfigs: Record<DeploymentStatus, StatusConfig> = {
-  awaiting_approval: {
-    icon: LayerFront,
-    label: "Awaiting Approval",
-    bgColor: "bg-warningA-3",
-    textColor: "text-warningA-11",
-    iconColor: "text-warning-11",
-  },
   pending: {
     icon: LayerFront,
     label: "Pending",
@@ -92,13 +85,6 @@ const statusConfigs: Record<DeploymentStatus, StatusConfig> = {
     textColor: "text-errorA-11",
     iconColor: "text-error-11",
   },
-  rejected: {
-    icon: CircleWarning,
-    label: "Rejected",
-    bgColor: "bg-errorA-3",
-    textColor: "text-errorA-11",
-    iconColor: "text-error-11",
-  },
 };
 
 type DeploymentStatusBadgeProps = {

web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/components/deployment-status-badge.tsx

@@ -1,5 +1,4 @@
 export const DEPLOYMENT_STATUSES = [
-  "awaiting_approval",
   "pending",
   "starting",
   "building",
@@ -8,7 +7,6 @@ export const DEPLOYMENT_STATUSES = [
   "finalizing",
   "ready",
   "failed",
-  "rejected",
 ] as const;
 
 export type DeploymentStatus = (typeof DEPLOYMENT_STATUSES)[number];

web/apps/dashboard/lib/collections/deploy/deployment-status.ts

@@ -0,0 +1,28 @@
+import { env } from "@/lib/env";
+import type { DescService } from "@bufbuild/protobuf";
+import { type Client, createClient } from "@connectrpc/connect";
+import { createConnectTransport } from "@connectrpc/connect-web";
+import { TRPCError } from "@trpc/server";
+
+export function createCtrlClient<T extends DescService>(service: T): Client<T> {
+  const { CTRL_URL, CTRL_API_KEY } = env();
+  if (!CTRL_URL || !CTRL_API_KEY) {
+    throw new TRPCError({
+      code: "PRECONDITION_FAILED",
+      message: "ctrl service is not configured",
+    });
+  }
+
+  return createClient(
+    service,
+    createConnectTransport({
+      baseUrl: CTRL_URL,
+      interceptors: [
+        (next) => (req) => {
+          req.header.set("Authorization", `Bearer ${CTRL_API_KEY}`);
+          return next(req);
+        },
+      ],
+    }),
+  );
+}

web/apps/dashboard/lib/ctrl-client.ts

@@ -1,9 +1,8 @@
 import { CustomDomainService } from "@/gen/proto/ctrl/v1/custom_domain_pb";
+import { createCtrlClient } from "@/lib/ctrl-client";
 import { db } from "@/lib/db";
-import { env } from "@/lib/env";
 import { ratelimit, withRatelimit, workspaceProcedure } from "@/lib/trpc/trpc";
-import { Code, ConnectError, createClient } from "@connectrpc/connect";
-import { createConnectTransport } from "@connectrpc/connect-web";
+import { Code, ConnectError } from "@connectrpc/connect";
 import { TRPCError } from "@trpc/server";
 import { z } from "zod";
 
@@ -17,13 +16,7 @@ export const addCustomDomain = workspaceProcedure
     }),
   )
   .mutation(async ({ input, ctx }) => {
-    const { CTRL_URL, CTRL_API_KEY } = env();
-    if (!CTRL_URL || !CTRL_API_KEY) {
-      throw new TRPCError({
-        code: "PRECONDITION_FAILED",
-        message: "ctrl service is not configured",
-      });
-    }
+    const ctrl = createCtrlClient(CustomDomainService);
 
     // Verify project belongs to workspace
     const project = await db.query.projects.findFirst({
@@ -60,19 +53,6 @@ export const addCustomDomain = workspaceProcedure
 
     const appId = environment.appId;
 
-    const ctrl = createClient(
-      CustomDomainService,
-      createConnectTransport({
-        baseUrl: CTRL_URL,
-        interceptors: [
-          (next) => (req) => {
-            req.header.set("Authorization", `Bearer ${CTRL_API_KEY}`);
-            return next(req);
-          },
-        ],
-      }),
-    );
-
     try {
       const response = await ctrl.addCustomDomain({
         workspaceId: ctx.workspace.id,

web/apps/dashboard/lib/trpc/routers/deploy/custom-domains/add.ts

@@ -1,9 +1,7 @@
 import { CustomDomainService } from "@/gen/proto/ctrl/v1/custom_domain_pb";
+import { createCtrlClient } from "@/lib/ctrl-client";
 import { db } from "@/lib/db";
-import { env } from "@/lib/env";
 import { ratelimit, withRatelimit, workspaceProcedure } from "@/lib/trpc/trpc";
-import { createClient } from "@connectrpc/connect";
-import { createConnectTransport } from "@connectrpc/connect-web";
 import { TRPCError } from "@trpc/server";
 import { z } from "zod";
 
@@ -16,13 +14,7 @@ export const deleteCustomDomain = workspaceProcedure
     }),
   )
   .mutation(async ({ input, ctx }) => {
-    const { CTRL_URL, CTRL_API_KEY } = env();
-    if (!CTRL_URL || !CTRL_API_KEY) {
-      throw new TRPCError({
-        code: "PRECONDITION_FAILED",
-        message: "ctrl service is not configured",
-      });
-    }
+    const ctrl = createCtrlClient(CustomDomainService);
 
     // Verify project belongs to workspace
     const project = await db.query.projects.findFirst({
@@ -60,19 +52,6 @@ export const deleteCustomDomain = workspaceProcedure
       });
     }
 
-    const ctrl = createClient(
-      CustomDomainService,
-      createConnectTransport({
-        baseUrl: CTRL_URL,
-        interceptors: [
-          (next) => (req) => {
-            req.header.set("Authorization", `Bearer ${CTRL_API_KEY}`);
-            return next(req);
-          },
-        ],
-      }),
-    );
-
     try {
       await ctrl.deleteCustomDomain({
         workspaceId: ctx.workspace.id,

web/apps/dashboard/lib/trpc/routers/deploy/custom-domains/delete.ts

@@ -1,9 +1,7 @@
 import { CustomDomainService } from "@/gen/proto/ctrl/v1/custom_domain_pb";
+import { createCtrlClient } from "@/lib/ctrl-client";
 import { db } from "@/lib/db";
-import { env } from "@/lib/env";
 import { ratelimit, withRatelimit, workspaceProcedure } from "@/lib/trpc/trpc";
-import { createClient } from "@connectrpc/connect";
-import { createConnectTransport } from "@connectrpc/connect-web";
 import { TRPCError } from "@trpc/server";
 import { z } from "zod";
 
@@ -16,13 +14,7 @@ export const retryVerification = workspaceProcedure
     }),
   )
   .mutation(async ({ input, ctx }) => {
-    const { CTRL_URL, CTRL_API_KEY } = env();
-    if (!CTRL_URL || !CTRL_API_KEY) {
-      throw new TRPCError({
-        code: "PRECONDITION_FAILED",
-        message: "ctrl service is not configured",
-      });
-    }
+    const ctrl = createCtrlClient(CustomDomainService);
 
     // Verify project belongs to workspace
     const project = await db.query.projects.findFirst({
@@ -60,19 +52,6 @@ export const retryVerification = workspaceProcedure
       });
     }
 
-    const ctrl = createClient(
-      CustomDomainService,
-      createConnectTransport({
-        baseUrl: CTRL_URL,
-        interceptors: [
-          (next) => (req) => {
-            req.header.set("Authorization", `Bearer ${CTRL_API_KEY}`);
-            return next(req);
-          },
-        ],
-      }),
-    );
-
     try {
       const response = await ctrl.retryVerification({
         workspaceId: ctx.workspace.id,