fix: weird queries

Author: chronark

pkg/db/deployment_topology_find_regions.sql_generated.go

@@ -1,7 +1,7 @@
 -- name: FindDeploymentRegions :many
 -- Returns all regions where a deployment is configured.
 -- Used for fan-out: when a deployment changes, emit state_change to each region.
-SELECT r.name
+SELECT r.*
 FROM `deployment_topology` dt
 INNER JOIN `regions` r ON dt.region_id = r.id
 WHERE dt.deployment_id = sqlc.arg(deployment_id);

pkg/db/deployment_topology_update_desired_status.sql_generated.go

@@ -3,9 +3,4 @@
 -- A new version is required so that WatchDeployments picks up the change.
 UPDATE `deployment_topology`
 SET desired_status = sqlc.arg(desired_status), version = sqlc.arg(version), updated_at = sqlc.arg(updated_at)
-WHERE deployment_id = sqlc.arg(deployment_id) AND region_id = (
-    SELECT id
-    FROM `regions`
-    WHERE name = sqlc.arg(region)
-    LIMIT 1
-);
+WHERE deployment_id = sqlc.arg(deployment_id) AND region_id = sqlc.arg(region_id);

pkg/db/querier_generated.go

@@ -130,17 +130,17 @@ func (v *VirtualObject) ChangeDesiredState(ctx restate.ObjectContext, req *hydra
 
 	// Update all topology entries so WatchDeployments picks up the change.
 	// Each region needs a new version from VersioningService.
-	regions, err := restate.Run(ctx, func(runCtx restate.RunContext) ([]string, error) {
+	regions, err := restate.Run(ctx, func(runCtx restate.RunContext) ([]db.Region, error) {
 		return db.Query.FindDeploymentRegions(runCtx, v.db.RO(), deploymentID)
 	}, restate.WithName("find deployment regions"))
 	if err != nil {
 		return nil, fmt.Errorf("failed to find deployment regions: %w", err)
 	}
 
 	for _, region := range regions {
-		versionResp, err := hydrav1.NewVersioningServiceClient(ctx, region).NextVersion().Request(&hydrav1.NextVersionRequest{})
+		versionResp, err := hydrav1.NewVersioningServiceClient(ctx, region.ID).NextVersion().Request(&hydrav1.NextVersionRequest{})
 		if err != nil {
-			return nil, fmt.Errorf("failed to get next version for region %s: %w", region, err)
+			return nil, fmt.Errorf("failed to get next version for region %s: %w", region.ID, err)
 		}
 
 		err = restate.RunVoid(ctx, func(runCtx restate.RunContext) error {
@@ -149,9 +149,9 @@ func (v *VirtualObject) ChangeDesiredState(ctx restate.ObjectContext, req *hydra
 				Version:       versionResp.GetVersion(),
 				UpdatedAt:     sql.NullInt64{Valid: true, Int64: time.Now().UnixMilli()},
 				DeploymentID:  deploymentID,
-				Region:        region,
+				RegionID:      region.ID,
 			})
-		}, restate.WithName(fmt.Sprintf("updating topology desired status in %s", region)))
+		}, restate.WithName(fmt.Sprintf("updating topology desired status in %s", region.ID)))
 		if err != nil {
 			return nil, fmt.Errorf("failed to update topology desired status in %s: %w", region, err)
 		}