Clicking on a notification doesn't bring app window to focus

[skyblue002]

When receiving a notification about a new e-mail message, clicking on that notification opens the e-mail in the app, but doesn't bring the app itself into focus. If the app is behind others, it won't be seen. Other apps must be minimized or the ProtonMail app icon must be clicked in order to bring it into focus to see the e-mail that was opened.

Unofficial desktop client for ProtonMail 1.2.1
Electron 8.5.2
darwin x64 19.3.0

[kontrollanten]

Shit, I thought this was fixed with the latest release. But I'll check it when I get time.

[skyblue002]

I just ran the app through the Terminal, sent through a test e-mail, and got it to focus on the app when clicking on the notification. I'm not sure why it worked. It didn't work before — and that issue was consistent, even after restarting the app. Is there a way to check through logs or enable verbose mode when running from the Terminal? When I ran the app from the Terminal, it didn't give a lot of feedback. I'd be happy to help, I'm just not sure where to start. I'm really not sure if this was just by chance that it worked or if it's fixed.

Update: It's back to not working anymore. I'm not sure why. Just let me know if you need any logs or anything from me. Happy to help get the issue fixed. :)

[kontrollanten]

Thanks a lot for your help. When I run the app in dev mode it works to click on the notifications. Maybe it only works when the app is started from the terminal?

If you clone the repo and check https://github.com/unofficial-protonmail-desktop/application/blob/master/src/renderer/lib/webview-preload.js#L9 you'll see the code that runs within the mail.protonmail.com-webview. Line 9 sends data to the main runtime, which is catched in

application/src/main/index.js

Line 37 in 205a704

mainWindow.show();

If you add console.log statements in the main process it'll be shown in the terminal. It's a bit trickier to read the logging in the webview.

[skyblue002]

I managed to get it to show the app when clicking on a notification and it wasn't running from the Terminal or in dev mode. So, that wouldn't seem to be the issue here.

I'm not even sure how to begin with the code. The only Javascript I've ever done has been web-based.

I programmed a bit of Swift for the MacOS platform, but didn't do anything with push-type notifications. I did do something with higher-level scope notifications within the program, though. I needed two different aspects of the program to communicate with one another, so I created a listener and then would send out a signal targeted to that listener when appropriate. That allowed two different parts of the program, which were otherwise separate, to communicate with one another. I'm not sure if that's how you set things up with your app. If it is, it would seem like the problem is either in handling the click event of the notification, or getting it to the command to bring the window forward. I had some issues drawing focus away from other elements/windows when doing my own app. I had to program it to release the focus from other elements/windows first. I'm not sure why. It seemed like the focus was naturally taken by other elements/windows. So, once I explicitly told it to release the focus from others, I could tell it to set that focus where I wanted. I'm not sure if that's the issue here. It's just something that came to mind, given my own experience.

If you need logs (which I'd be willing to get for you), you'd have to walk me through how to get things to you, since Javascript outside the realm of a webpage really isn't something I'm experienced with. Just let me know. :)