chore: resolving PR comments

Co-authored-by: David <[email protected]>

Author: Kunal22shah

UI/MVUX/src/MVUX/Presentation/FeedSample/FeedModel.cs

@@ -4,22 +4,18 @@ namespace MVUX.Presentation.FeedSample;
 
 public partial record FeedModel
 {
-	public IFeed<Person> Person { get; }
-	
-	public FeedModel()
-	{
-		Person = Feed.Async(async ct =>
-		{
-			await Task.Delay(2000, ct);
-			
-			var people = new[]
+	private static readonly Person[] _people = new[]
 			{
 				new Person("Master", "Yoda"),
 				new Person("Darth", "Vader"),
 				new Person("Luke", "Skywalker")
 			};
-			
-			return people[new Random().Next(people.Length)];
+
+	public IFeed<Person> Person => Feed.Async(async ct =>
+		{
+			await Task.Delay(2000, ct); // Simulate network delay
+						
+			return _people[Random.Shared.Next(people.Length)];
 		});
 	}
 

UI/MVUX/src/MVUX/Presentation/FeedViewCommandSample/FeedViewCommandModel.cs

@@ -2,24 +2,17 @@ namespace MVUX.Presentation.FeedViewCommandSample;
 
 public partial class FeedViewCommandModel
 {
-	public IListState<Item> Items => ListState.Value(this, () =>
-	{
-		return ImmutableList.Create(
+	public IListState<Item> Items => ListState.Value(this, () => ImmutableList.Create(
 			new Item { Text = "Item 1" },
 			new Item { Text = "Item 2" },
 			new Item { Text = "Item 3" }
-			);
-	});
+		));
 
 	public async ValueTask RemoveItem(Item item)
 	{
 		if (item != null)
 		{
-			await Items.UpdateAsync(currentItems =>
-			{
-				var updatedItems = currentItems.Remove(item); 
-				return updatedItems;
-			});
+			await Items.UpdateAsync(currentItems => currentItems.Remove(item));
 		}
 	}
 }

UI/MVUX/src/MVUX/Presentation/IMessengerSample/PeopleService.cs

@@ -4,8 +4,7 @@ namespace MVUX.Presentation.IMessengerSample;
 
 public partial record Person(int Id, string FirstName, string LastName)
 {
-    public static Person EmptyPerson() =>
-      new Person(Id: default, FirstName: string.Empty, LastName: string.Empty);
+    public static Person Empty { get; } = new Person(Id: default, FirstName: string.Empty, LastName: string.Empty);
 }
 
 public interface IPeopleService

UI/MVUX/src/MVUX/Presentation/ListFeedSample/ListFeedModel.cs

@@ -11,7 +11,4 @@ public partial record ListFeedModel
 			new Person("Luke", "Skywalker")
 		);
 	});
-	public ListFeedModel()
-	{
-	}
 }

UI/MVUX/src/MVUX/Presentation/RefreshListFeed/RefreshSignalModel.cs

@@ -5,10 +5,6 @@ public partial record RefreshSignalModel
 		private readonly Signal _refreshList = new();
 		private int _updateCounter = 0;
 
-		public RefreshSignalModel()
-		{
-		}
-		
 		public IListFeed<string> SimpleList => ListFeed.Async(GetStringsAsync, _refreshList);
 
 		public async ValueTask<IImmutableList<string>> GetStringsAsync(CancellationToken ct)
@@ -25,9 +21,6 @@ public async ValueTask<IImmutableList<string>> GetStringsAsync(CancellationToken
 		}
 
 		public async ValueTask RefreshList()
-		{
-			_refreshList.Raise(); 
-			await Task.Delay(1000);
-		}
+			=> _refreshList.Raise(); 
 	}
 }