Merge pull request #21853 from unoplatform/mergify/bp/release/stable/6.4/pr-21829

fix: Make sure to not show temp files in HRI when doing HR with agent (backport #21829)

Author: agneszitte

src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.MetadataUpdate.cs

@@ -246,6 +246,7 @@ private async ValueTask ProcessSolutionChanged(HotReloadServerOperation hotReloa
 				else
 				{
 					_reporter.Verbose($"Could not find document with path {file} in the workspace.");
+					hotReload.NotifyIgnored(file);
 				}
 			}
 
@@ -270,7 +271,6 @@ private async ValueTask ProcessSolutionChanged(HotReloadServerOperation hotReloa
 			_reporter.Output($"Found {updates.Length} metadata updates after {sw.Elapsed}");
 			sw.Stop();
 
-
 			if (rudeEdits.IsEmpty && updates.IsEmpty)
 			{
 				var compilationErrors = GetCompilationErrors(solution, ct);

src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.cs

@@ -149,7 +149,7 @@ private async ValueTask Notify(HotReloadEvent evt, HotReloadEventSource source =
 			{
 				measurements = new Dictionary<string, double>
 				{
-					["FileCount"] = _current.FilePaths.Count
+					["FileCount"] = _current.ConsideredFilePaths.Count
 				};
 				if (_current.CompletionTime != null)
 				{
@@ -256,9 +256,10 @@ void LoadInfos(HotReloadServerOperation? operation)
 							?.Where(d => d.Severity >= DiagnosticSeverity.Warning)
 							.Select(d => CSharpDiagnosticFormatter.Instance.Format(d, CultureInfo.InvariantCulture))
 							.ToImmutableList() ?? ImmutableList<string>.Empty;
+						var files = operation.ConsideredFilePaths.Except(operation.IgnoredFilePaths);
 
 						foundCompleting |= operation == completing;
-						infos.Add(new(operation.Id, operation.StartTime, operation.FilePaths, operation.CompletionTime, operation.Result, diagnosticsResult));
+						infos.Add(new(operation.Id, operation.StartTime, files, operation.IgnoredFilePaths, operation.CompletionTime, operation.Result, diagnosticsResult));
 						operation = operation.Previous!;
 					}
 				}
@@ -286,7 +287,8 @@ private class HotReloadServerOperation
 			private readonly HotReloadServerOperation? _previous;
 			private readonly Timer _timeout;
 
-			private ImmutableHashSet<string> _filePaths;
+			private ImmutableHashSet<string> _consideredFilePaths; // All files that have been considered for this operation.
+			private ImmutableHashSet<string> _ignoredFilePaths = _empty; // The files that have been ignored by the compilator for this operation (basically because they are not part of the solution).
 			private int /* HotReloadResult */ _result = -1;
 			private CancellationTokenSource? _deferredCompletion;
 			private ImmutableArray<Diagnostic>? _diagnostics;
@@ -304,7 +306,19 @@ private class HotReloadServerOperation
 
 			public HotReloadServerOperation? Previous => _previous;
 
-			public ImmutableHashSet<string> FilePaths => _filePaths;
+			/// <summary>
+			/// List of all file paths that have been considered for this hot-reload operation.
+			/// </summary>
+			/// <remarks>This **includes** the <see cref="IgnoredFilePaths"/>.</remarks>
+			public ImmutableHashSet<string> ConsideredFilePaths => _consideredFilePaths;
+
+			/// <summary>
+			/// Gets the collection of file paths that are excluded from processing.
+			/// </summary>
+			/// <remarks>
+			/// Files are typically ignored when they do not yet exist in the current solution.
+			/// </remarks>
+			public ImmutableHashSet<string> IgnoredFilePaths => _ignoredFilePaths;
 
 			public ImmutableArray<Diagnostic>? Diagnostics => _diagnostics;
 
@@ -315,7 +329,7 @@ public HotReloadServerOperation(ServerHotReloadProcessor owner, HotReloadServerO
 			{
 				_owner = owner;
 				_previous = previous;
-				_filePaths = filePaths ?? _empty;
+				_consideredFilePaths = filePaths ?? _empty;
 
 				_timeout = new Timer(
 					static that => _ = ((HotReloadServerOperation)that!).Complete(HotReloadServerResult.Aborted),
@@ -325,7 +339,7 @@ public HotReloadServerOperation(ServerHotReloadProcessor owner, HotReloadServerO
 			}
 
 			/// <summary>
-			/// Attempts to update the <see cref="FilePaths"/> if we determine that the provided paths are corresponding to this operation.
+			/// Attempts to update the <see cref="ConsideredFilePaths"/> if we determine that the provided paths are corresponding to this operation.
 			/// </summary>
 			/// <returns>
 			/// True if this operation should be considered as valid for the given file paths (and has been merged with original paths),
@@ -338,7 +352,7 @@ public bool TryMerge(ImmutableHashSet<string> filePaths)
 					return false;
 				}
 
-				var original = _filePaths;
+				var original = _consideredFilePaths;
 				while (true)
 				{
 					ImmutableHashSet<string> updated;
@@ -355,7 +369,7 @@ public bool TryMerge(ImmutableHashSet<string> filePaths)
 						return false;
 					}
 
-					var current = Interlocked.CompareExchange(ref _filePaths, updated, original);
+					var current = Interlocked.CompareExchange(ref _consideredFilePaths, updated, original);
 					if (current == original)
 					{
 						_timeout.Change(_timeoutDelay, Timeout.InfiniteTimeSpan);
@@ -377,6 +391,13 @@ public void EnableAutoRetryIfNoChanges(int? attempts, TimeSpan? delay)
 				_noChangesRetryDelay = delay ?? DefaultAutoRetryIfNoChangesDelay;
 			}
 
+			/// <summary>
+			/// Notifies a file has been ignored for this hot-reload operation.
+			/// </summary>
+			/// <param name="file"></param>
+			public void NotifyIgnored(string file)
+				=> ImmutableInterlocked.Update(ref _ignoredFilePaths, static (files, file) => files.Add(file), file);
+
 			/// <summary>
 			/// As errors might get a bit after the complete from the IDE, we can defer the completion of the operation.
 			/// </summary>

src/Uno.UI.RemoteControl/HotReload/Messages/HotReloadStatusMessage.cs

@@ -35,6 +35,7 @@ public record HotReloadServerOperationData(
 		long Id,
 		DateTimeOffset StartTime,
 		ImmutableHashSet<string> FilePaths,
+		ImmutableHashSet<string>? IgnoredFilePaths,
 		DateTimeOffset? EndTime,
 		HotReloadServerResult? Result,
 		IImmutableList<string>? Diagnostics);