Commit 429b438
authored
fix(onboarding): add explicit EFI loader path for flash entry (#1926)
## Summary
- update API onboarding internal-boot BIOS update flow to create the
flash UEFI entry with an explicit loader path
- keep scope API-only (no webgui repo changes)
- update onboarding internal-boot service spec to assert the new
efibootmgr args
## Why
Some motherboards fail to boot the USB entry in UEFI mode when the NVRAM
boot entry is created without an explicit loader path, even when
`EFI/BOOT/BOOTX64.EFI` exists.
## Change Details
- flash boot entry command now includes `-l \EFI\BOOT\BOOTX64.EFI`
- internal boot entry behavior is unchanged
## Testing
- attempted: `pnpm --filter ./api test
src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.spec.ts`
- note: not executed in this fresh worktree because dependencies are not
installed (`vitest: command not found`)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Bug Fixes**
* Boot entry creation now includes the EFI loader path, improving
reliability of system boot setup.
* Skips creating BIOS entries for disks that cannot be resolved from
assignable disks and avoids adding invalid boot entries.
* **Improvements**
* Internal-boot UI now prefers disk serial number first (then disk ID,
then device) for more consistent selection.
* Expanded diagnostic and debug logging around boot device resolution
and BIOS/boot update flows.
* **Tests**
* Tests updated to cover assignable-disk resolution, expected output
messages for unresolved disks, and BIOS update paths.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->1 parent bae2e8b commit 429b438
File tree
4 files changed
+157
-60
lines changed- api/src/unraid-api/graph/resolvers/onboarding
- web/src/components/Onboarding/steps
4 files changed
+157
-60
lines changedLines changed: 21 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
213 | 220 | | |
214 | 221 | | |
215 | 222 | | |
| |||
262 | 269 | | |
263 | 270 | | |
264 | 271 | | |
265 | | - | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
266 | 276 | | |
267 | 277 | | |
268 | 278 | | |
| |||
286 | 296 | | |
287 | 297 | | |
288 | 298 | | |
289 | | - | |
| 299 | + | |
290 | 300 | | |
291 | 301 | | |
292 | 302 | | |
| |||
327 | 337 | | |
328 | 338 | | |
329 | 339 | | |
330 | | - | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
331 | 344 | | |
332 | 345 | | |
333 | 346 | | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
334 | 352 | | |
335 | 353 | | |
336 | 354 | | |
| |||
0 commit comments