Skip to content

Commit ffeb148

Browse files
authored
fix: Revert "fix(web): avoid legacy dropdown id collisions" (#1961)
Reverts #1961
1 parent c392146 commit ffeb148

File tree

3 files changed

+0
-105
lines changed

3 files changed

+0
-105
lines changed

web/__test__/components/Wrapper/mount-engine.test.ts

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -248,28 +248,6 @@ describe('mount-engine', () => {
248248
expect(lastUAppPortal).toBe('#unraid-api-modals-virtual');
249249
});
250250

251-
it('should sanitize conflicting dropdown ids that legacy plugins target', async () => {
252-
await mountUnifiedApp();
253-
254-
const trigger = document.createElement('button');
255-
trigger.setAttribute('id', 'reka-dropdown-menu-trigger-1');
256-
document.body.appendChild(trigger);
257-
258-
const content = document.createElement('div');
259-
content.setAttribute('id', 'reka-dropdown-menu-content-1');
260-
content.setAttribute('aria-labelledby', 'reka-dropdown-menu-trigger-1');
261-
document.body.appendChild(content);
262-
263-
trigger.setAttribute('aria-controls', 'reka-dropdown-menu-content-1');
264-
265-
await vi.waitFor(() => {
266-
expect(trigger.getAttribute('id')).toBe('reka-menu-trigger-1');
267-
expect(trigger.getAttribute('aria-controls')).toBe('reka-menu-content-1');
268-
expect(content.getAttribute('id')).toBe('reka-menu-content-1');
269-
expect(content.getAttribute('aria-labelledby')).toBe('reka-menu-trigger-1');
270-
});
271-
});
272-
273251
it('should decorate the parent container when requested', async () => {
274252
const container = document.createElement('div');
275253
container.id = 'container';

web/src/components/Wrapper/mount-engine.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import { createI18nInstance, ensureLocale, getWindowLocale } from '~/helpers/i18
1111

1212
// Import Pinia for use in Vue apps
1313
import { globalPinia } from '~/store/globalPinia';
14-
import { enableDropdownIdCompatibility } from '~/utils/dropdownIdCompatibility';
1514
import { ensureUnapiScope, ensureUnapiScopeForSelectors, observeUnapiScope } from '~/utils/unapiScope';
1615

1716
// Ensure Apollo client is singleton
@@ -129,8 +128,6 @@ function parsePropsFromElement(element: Element): Record<string, unknown> {
129128

130129
// Create and mount unified app with shared context
131130
export async function mountUnifiedApp() {
132-
enableDropdownIdCompatibility();
133-
134131
// Create a minimal app just for context sharing
135132
const app = createApp({
136133
name: 'UnifiedContextApp',

web/src/utils/dropdownIdCompatibility.ts

Lines changed: 0 additions & 80 deletions
This file was deleted.

0 commit comments

Comments
 (0)