hidebans: the banlist was accidentally hidden even for chanops.

syzop · syzop · commit b72c3a98b90c · 2023-03-11T18:37:50.000+01:00
The modes were not hidden to chanops but all the +beI lists were
(MODE #channel b).

Reported by Nini.
diff --git a/files/hidebans.c b/files/hidebans.c
@@ -84,7 +84,8 @@ int hidebans_packet(Client *from, Client *to, Client *intended_to, char **msg, i
 	if (!strncmp(p, "367 ", 4) || !strncmp(p, "348 ", 4) || !strncmp(p, "346 ", 4)) /* +b, +e, +I */
 	{
 		/* +beI list results */
-		if (hidebans_isskochanop(p+4, to))
+		p = strchr(p+4, ' ');
+		if (p && hidebans_isskochanop(p+1, to))
 			return 0; /* show as-is if chanop */
 		
 		/* otherwise, drop it.. */

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,8 @@ int hidebans_packet(Client from, Client to, Client intended_to, char *msg, i`
`84`	`84`	`if (!strncmp(p, "367 ", 4) \|\| !strncmp(p, "348 ", 4) \|\| !strncmp(p, "346 ", 4)) /* +b, +e, +I */`
`85`	`85`	`{`
`86`	`86`	`/* +beI list results */`
`87`		`- if (hidebans_isskochanop(p+4, to))`
	`87`	`+ p = strchr(p+4, ' ');`
	`88`	`+ if (p && hidebans_isskochanop(p+1, to))`
`88`	`89`	`return 0; /* show as-is if chanop */`
`89`	`90`
`90`	`91`	`/* otherwise, drop it.. */`