fix: task auto completion should not add waste ] (#105)

Author: unvalley

src/features/editor/codemirror/tasklist/auto-complete.browser.test.ts

@@ -82,6 +82,14 @@ describe("taskAutoComplete", () => {
     expect(result.cursorPosition).toBe(6);
   });
 
+  test("auto-complete removes existing closing bracket for '-[]' pattern", () => {
+    const result = testAutoComplete("-[]", 2, " ");
+
+    expect(result.before).toBe("-[]");
+    expect(result.after).toBe("- [ ] ");
+    expect(result.cursorPosition).toBe(6);
+  });
+
   test("auto-complete with indented '- [ ' pattern", () => {
     const result = testAutoComplete("  - [", 5, " ");
 

src/features/editor/codemirror/tasklist/auto-complete.ts

@@ -2,32 +2,37 @@ import type { Extension } from "@codemirror/state";
 import { EditorView } from "@codemirror/view";
 
 export const taskAutoComplete: Extension = EditorView.inputHandler.of((view, from, to, text) => {
-  const isValidInput = text === " " && from === to && from >= 2;
-  if (!isValidInput) return false;
+  const isWhitespaceInput = from === to && text.length > 0 && /^[ \t]+$/.test(text);
+  if (!isWhitespaceInput) return false;
 
   const doc = view.state.doc;
   const line = doc.lineAt(from);
-  const linePrefix = doc.sliceString(line.from, from);
+  const before = doc.sliceString(line.from, from);
+  const after = doc.sliceString(from, line.to);
 
-  const patterns = [
-    { suffix: "- [", offset: 3 },
-    { suffix: "-[", offset: 2 },
-  ];
+  const bulletMatch = before.match(/[-*]\s*\[$/);
+  if (!bulletMatch) return false;
 
-  const matchedPattern = patterns.find(({ suffix }) => linePrefix.endsWith(suffix));
-  if (!matchedPattern) return false;
+  const bulletStart = before.length - bulletMatch[0].length;
+  const indent = before.slice(0, bulletStart);
+  if (!/^[ \t]*$/.test(indent)) return false;
 
-  const insertFrom = from - matchedPattern.offset;
-  if (insertFrom < line.from) return false;
+  // Avoid re-triggering on existing task list items like "- [ ]" or "- [x]"
+  if (/^[ \t]*(?:[xX]\]| \])/.test(after)) return false;
 
-  const replacement = "- [ ] ";
+  const insertFrom = line.from;
+  const bullet = bulletMatch[0][0];
+  const replacement = `${indent}${bullet} [ ] `;
+  // don't remove waste `]`
+  const replaceTo = after.startsWith("]") && from + 1 <= line.to ? from + 1 : from;
 
   view.dispatch({
     changes: {
       from: insertFrom,
-      to: from,
+      to: replaceTo,
       insert: replacement,
     },
+    userEvent: "input.taskAutoComplete",
     selection: { anchor: insertFrom + replacement.length },
   });