coll xhc: ensure to initialize member_id

In reality, it's extremely unlikely (or possibly impossible?) for
member_id to get through the loop without being assigned.  But gcc
14's static analyzer flags it as possible and emits a warning. So
initially assign it to -1 and put in an assert() to catch (in debug
builds) if it isn't assigned.

Signed-off-by: Jeff Squyres <[email protected]>

Author: jsquyres

ompi/mca/coll/xhc/coll_xhc_module.c

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2021-2023 Computer Architecture and VLSI Systems (CARV)
  *                         Laboratory, ICS Forth. All rights reserved.
+ * Copyright (c) 2024      Jeffrey M. Squyres.  All rights reserved.
  * $COPYRIGHT$
  *
  * Additional copyrights may follow
@@ -523,7 +524,7 @@ static int xhc_module_create_hierarchy(xhc_module_t *module,
             continue;
         }
 
-        int member_id;
+        int member_id = -1;
         int members = 0;
 
         // If working with rank list, set the ranks from the list as "local"
@@ -560,6 +561,8 @@ static int xhc_module_create_hierarchy(xhc_module_t *module,
             }
         }
 
+        assert(member_id != -1);
+
         /* If split or max ranks was specified, math partition the locality
          * and remove the previously added locality mapping to some ranks */
         if(my_def->split > 1) {