Refactored the --with-prrte configure option to reject building Open MPI against external installs of PRRTE #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
reviewed
Nov 5, 2024
alexandria-sisk
force-pushed
the
alexsisk/refactor-prrte-config-option
branch
4 times, most recently
from
2fb05ce to
7adcecf
Compare
|
@alexandria-sisk I think your code isn't working -- check out line 4043 in the macOS build CI results in the "Build Open MPI" section: This suggests that the PRRTE |
…l PRRTE builds Signed-off-by: Alexandria Sisk <[email protected]>
alexandria-sisk
force-pushed
the
alexsisk/refactor-prrte-config-option
branch
from
44f6564 to
9222192
Compare
jsquyres
force-pushed
the
alexsisk/refactor-prrte-config-option
branch
from
9222192 to
fae7249
Compare
alexandria-sisk
force-pushed
the
alexsisk/refactor-prrte-config-option
branch
from
fae7249 to
375245f
Compare
Signed-off-by: Alexandria Sisk <[email protected]>
alexandria-sisk
force-pushed
the
alexsisk/refactor-prrte-config-option
branch
from
375245f to
a8e87f7
Compare
jsquyres
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the --with-prrte configure option to only accept "yes" , "no", or nothing as arguments. The --with-prrte option previously allowed for building Open MPI against external installations of PRRTE which we no longer want to support. Any paths to external PRRTE builds given to this configure option will be rejected.