Skip to content

Commit 9db0d5b

Browse files
committed
Change Setter UI in Upa URL demo page
1 parent fc73b9e commit 9db0d5b

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

demo/index.html

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,10 @@ <h1>Upa URL demo</h1>
1919
<input id="base" class="field" value="https://example.org/">
2020

2121
<div class="label">
22-
<select id="setter"><option value=""></option></select>
23-
<label for="setter-inp">setter:</label>
22+
<input type="checkbox" id="use-setter">
23+
<label for="use-setter">set</label>
24+
<select id="setter"></select>
25+
<label for="setter-inp">to:</label>
2426
</div>
2527
<input id="setter-inp" class="field" value="">
2628
</form>

demo/url-demo.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function getUrl() {
1818
? new Module.URL(elemUrl.value, elemBase.value)
1919
: new Module.URL(elemUrl.value);
2020
// apply setter
21-
if (elemSetter.value.length !== 0)
21+
if (elemUseSetter.checked)
2222
url[elemSetter.value] = elemSetterInp.value;
2323
return url;
2424
}
@@ -48,19 +48,22 @@ function onInpChange() {
4848
}
4949

5050
function onSetterChange() {
51-
elemSetterInp.disabled = elemSetter.value.length === 0;
51+
elemSetter.disabled = !elemUseSetter.checked;
52+
elemSetterInp.disabled = !elemUseSetter.checked;
5253
onInpChange();
5354
}
5455

5556
// Input elements
5657
const elemUrl = document.getElementById("url");
5758
const elemBase = document.getElementById("base");
59+
const elemUseSetter = document.getElementById("use-setter");
5860
const elemSetter = document.getElementById("setter");
5961
const elemSetterInp = document.getElementById("setter-inp");
6062

6163
// After text change
6264
elemUrl.addEventListener("input", onInpChange);
6365
elemBase.addEventListener("input", onInpChange);
66+
elemUseSetter.addEventListener("change", onSetterChange);
6467
elemSetter.addEventListener("change", onSetterChange);
6568
elemSetterInp.addEventListener("input", onInpChange);
6669

0 commit comments

Comments
 (0)