Add the PSL's push function that supports bytes as input

Author: rmisev

src/upa_url_bind.cpp

@@ -29,6 +29,10 @@ inline std::string_view to_string_view(nb::str str) {
     return {};
 }
 
+inline std::string_view to_string_view(nb::bytes bytes) {
+    return { bytes.c_str(), bytes.size() };
+}
+
 inline nb::str to_str(std::string_view sv) {
     return nb::str{ sv.data(), sv.length() };
 }
@@ -41,6 +45,9 @@ class public_suffix_list_py : public upa::public_suffix_list {
     inline void push(std::string_view buff) {
         upa::public_suffix_list::push(ctx_, buff);
     }
+    inline void push_bytes(nb::bytes bytes) {
+        upa::public_suffix_list::push(ctx_, to_string_view(bytes));
+    }
     inline bool finalize() {
         return upa::public_suffix_list::finalize(ctx_);
     }
@@ -201,6 +208,7 @@ NB_MODULE(upa_url, m) {
         .def(nb::init<>())
         .def("push_line", &public_suffix_list_py::push_line, nb::arg("line"))
         .def("push", &public_suffix_list_py::push, nb::arg("buff"))
+        .def("push", &public_suffix_list_py::push_bytes, nb::arg("buff"))
         .def("finalize", &public_suffix_list_py::finalize)
 
         // Load Public Suffix List from file

tests/test_psl.py

@@ -16,7 +16,9 @@ def test_psl_push(self):
         psl = PSL()
         psl.push('githu')
         psl.push('b.io')
+        psl.push(b'\ngov.lt')
         self.assertTrue(psl.finalize())
+        self.assertEqual(psl.public_suffix('data.gov.lt'), 'gov.lt')
         self.assertEqual(psl.public_suffix('upa-url.github.io.'), 'github.io.')
         self.assertEqual(psl.public_suffix('abc.io.'), 'io.')