Skip to content

Commit 98a11da

Browse files
authored
Merge pull request #31 from uphold/support/remove-user-agent
Remove user-agent default header
2 parents d57c34e + 74e1970 commit 98a11da

File tree

4 files changed

+3
-18
lines changed

4 files changed

+3
-18
lines changed

docs/client.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ export default class extends SDK {
3535

3636
```json
3737
{
38-
"defaultHeaders": {
39-
"user-agent": "uphold-sdk-javascript/<version>"
40-
}
38+
"defaultHeaders": {}
4139
}
4240
```
4341

src/core/services/client.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import { name, version } from '../../../package.json';
2-
31
export default class Client {
42
constructor() {
5-
this.defaultHeaders = { 'user-agent': `${name}/${version}` };
3+
this.defaultHeaders = {};
64
}
75
}

test/browser/services/fetch-client.spec.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { FetchClient, NotFoundError, UnavailableError } from '../../../src/browser';
2-
import { version } from '../../../package.json';
32
import fetchMock from 'fetch-mock';
43

54
describe('FetchClient', () => {
@@ -19,15 +18,6 @@ describe('FetchClient', () => {
1918
});
2019
});
2120

22-
it('should send a `User-Agent` header', () => {
23-
fetchMock.mock('foo', {});
24-
25-
return client.request('foo')
26-
.then(() => {
27-
expect(fetchMock.lastOptions().headers.get('user-agent')).toBe(`@uphold/uphold-sdk-javascript/${version}`);
28-
});
29-
});
30-
3121
it('should send given `body` and `headers`', () => {
3222
fetchMock.mock('foo', {});
3323

test/core/services/client.spec.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
import { Client } from '../../../src/core';
2-
import { name, version } from '../../../package.json';
32

43
describe('Client', () => {
54
describe('constructor()', () => {
65
it('should set `defaultHeaders` property', () => {
7-
expect(new Client().defaultHeaders).toEqual({ 'user-agent': `${name}/${version}` });
6+
expect(new Client().defaultHeaders).toEqual({});
87
});
98
});
109
});

0 commit comments

Comments
 (0)