Skip to content

Commit 2912dc2

Browse files
committed
Fail integration tests on missing env vars instead of skipping
Restore the original fail-loudly behavior that existed before this PR (via env.MustGet). Silently skipping can hide CI misconfigurations, making tests appear green when they aren't actually running.
1 parent 21b8f7d commit 2912dc2

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

test/file.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ func fileLocalCopy(t *testing.T, r *testenv.Runner) {
8181

8282
func fileRemoteCopy(t *testing.T, r *testenv.Runner) {
8383
if r.Artifacts.CustomStorage == "" {
84-
t.Skip("skipping: CUSTOM_STORAGE_BUCKET env var required")
84+
t.Fatal("CUSTOM_STORAGE_BUCKET env var is required")
8585
}
8686
ctx := context.Background()
8787
_, err := r.File.RemoteCopy(

test/integration_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ func TestIntegration(t *testing.T) {
4646
secretKey := os.Getenv("SECRET_KEY")
4747
publicKey := os.Getenv("PUBLIC_KEY")
4848
if secretKey == "" || publicKey == "" {
49-
t.Skip("skipping integration test: SECRET_KEY and PUBLIC_KEY env vars required")
49+
t.Fatal("SECRET_KEY and PUBLIC_KEY env vars are required")
5050
}
5151

5252
creds := ucare.APICreds{

0 commit comments

Comments
 (0)