Skip to content

Commit 52b7f71

Browse files
committed
Fix remaining PR review comments
- Remove byebug debug require from multipart_uploader_client.rb (CRITICAL) - Fix method naming consistency in AddOns: remove 'check_' prefix from aws_rekognition_detect_moderation_labels_status - Update corresponding test to match renamed method All tests passing (310 examples, 0 failures)
1 parent 850ca89 commit 52b7f71

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

lib/uploadcare/clients/multipart_uploader_client.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# frozen_string_literal: true
22

33
require 'thread'
4-
require 'byebug'
54
# require 'client/multipart_upload/chunks_client'
65
# require_relative 'upload_client'
76
module Uploadcare

lib/uploadcare/resources/add_ons.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def aws_rekognition_detect_moderation_labels(uuid, config = Uploadcare.configura
3636
# @param request_id [String] The Request ID from the Add-On execution
3737
# @return [Uploadcare::AddOns] An instance of AddOns with the status data
3838
# @see https://uploadcare.com/api-refs/rest-api/v0.7.0/#tag/Add-Ons/operation/awsRekognitionDetectModerationLabelsExecutionStatus
39-
def check_aws_rekognition_detect_moderation_labels_status(request_id, config = Uploadcare.configuration)
39+
def aws_rekognition_detect_moderation_labels_status(request_id, config = Uploadcare.configuration)
4040
response = add_ons_client(config).aws_rekognition_detect_moderation_labels_status(request_id)
4141
new(response, config)
4242
end

spec/uploadcare/resources/add_ons_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,15 @@
5353
end
5454
end
5555

56-
describe '.check_aws_rekognition_detect_moderation_labels_status' do
56+
describe '.aws_rekognition_detect_moderation_labels_status' do
5757
let(:response_body) { { 'status' => 'in_progress' } }
5858

5959
before do
6060
allow(add_ons_client).to receive(:aws_rekognition_detect_moderation_labels_status).with(request_id).and_return(response_body)
6161
end
6262

6363
it 'returns an instance of AddOns and assigns the status' do
64-
result = described_class.check_aws_rekognition_detect_moderation_labels_status(request_id)
64+
result = described_class.aws_rekognition_detect_moderation_labels_status(request_id)
6565
expect(result).to be_a(described_class)
6666
expect(result.status).to eq('in_progress')
6767
end

0 commit comments

Comments
 (0)