Skip to content

Commit 6f0b3f3

Browse files
committed
New rubocop fixes
1 parent 8335ce0 commit 6f0b3f3

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

lib/uploadcare/client/webhook_client.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def create(options = {})
1313
body = {
1414
target_url: options[:target_url],
1515
event: options[:event] || 'file.uploaded',
16-
is_active: options[:is_active].nil? ? true : options[:is_active]
16+
is_active: options[:is_active].nil? || options[:is_active]
1717
}.merge(
1818
{ signing_secret: options[:signing_secret] }.compact
1919
).to_json

lib/uploadcare/param/conversion/video/processing_job_url_builder.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def size_part(size)
2929
return if size.empty?
3030

3131
dimensions = "#{size[:width]}x#{size[:height]}" if size[:width] || size[:height]
32-
resize_mode = (size[:resize_mode]).to_s
32+
resize_mode = size[:resize_mode].to_s
3333
"/size/#{dimensions}/#{resize_mode}/".squeeze('/')
3434
end
3535

spec/uploadcare/client/conversion/video_convertion_client_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ module Conversion
3838

3939
%i[size quality format cut thumbs].each do |param|
4040
context "when only :#{param} param is present" do
41-
let(:arguments) { super().select { |k, _v| [:uuid, param].include?(k) } }
41+
let(:arguments) { super().slice(:uuid, param) }
4242

4343
it_behaves_like 'requesting video conversion'
4444
end

spec/uploadcare/entity/conversion/video_converter_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ module Conversion
4545

4646
%i[size quality format cut thumbs].each do |param|
4747
context "when only :#{param} param is present" do
48-
let(:arguments) { super().select { |k, _v| [:uuid, param].include?(k) } }
48+
let(:arguments) { super().slice(:uuid, param) }
4949

5050
it_behaves_like 'converts videos'
5151
end

spec/uploadcare/param/conversion/video/processing_job_url_builder_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ module Video
4343
end
4444

4545
context 'and when only the :size operation is present' do
46-
let(:arguments) { super().select { |k, _v| %i[uuid size].include?(k) } }
46+
let(:arguments) { super().slice(:uuid, :size) }
4747
let(:expected_url) do
4848
"#{uuid}/video/-" \
4949
"/size/#{arguments[:size][:width]}x#{arguments[:size][:height]}/#{arguments[:size][:resize_mode]}/"
@@ -54,15 +54,15 @@ module Video
5454

5555
%i[quality format].each do |param|
5656
context "and when only the :#{param} operation is present" do
57-
let(:arguments) { super().select { |k, _v| [:uuid, param].include?(k) } }
57+
let(:arguments) { super().slice(:uuid, param) }
5858
let(:expected_url) { "#{uuid}/video/-/#{param}/#{arguments[param]}/" }
5959

6060
it_behaves_like 'URL building'
6161
end
6262
end
6363

6464
context 'and when only the :cut operation is present' do
65-
let(:arguments) { super().select { |k, _v| %i[uuid cut].include?(k) } }
65+
let(:arguments) { super().slice(:uuid, :cut) }
6666
let(:expected_url) do
6767
"#{uuid}/video/-/cut/#{arguments[:cut][:start_time]}/#{arguments[:cut][:length]}/"
6868
end
@@ -71,7 +71,7 @@ module Video
7171
end
7272

7373
context 'and when only the :thumbs operation is present' do
74-
let(:arguments) { super().select { |k, _v| %i[uuid thumbs].include?(k) } }
74+
let(:arguments) { super().slice(:uuid, :thumbs) }
7575
let(:expected_url) do
7676
"#{uuid}/video/-/thumbs~#{arguments[:thumbs][:N]}/#{arguments[:thumbs][:number]}/"
7777
end

0 commit comments

Comments
 (0)