Skip to content

Commit 095d0c8

Browse files
committed
Handle exceptions when terminating processes gracefully.(As suggested by coderabbit)
1 parent 98f0193 commit 095d0c8

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

app.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,16 +88,18 @@ def stop_all_processes():
8888
# Terminate LSL process
8989
if lsl_process and lsl_process.poll() is None:
9090
lsl_process.terminate()
91-
lsl_process.wait(timeout=3)
92-
if lsl_process.poll() is None:
91+
try:
92+
lsl_process.wait(timeout=3)
93+
except subprocess.TimeoutExpired:
9394
lsl_process.kill()
9495

9596
# Terminate all app processes
9697
for app_name, process in app_processes.items():
9798
if process.poll() is None:
9899
process.terminate()
99-
process.wait(timeout=3)
100-
if process.poll() is None:
100+
try:
101+
process.wait(timeout=3)
102+
except subprocess.TimeoutExpired:
101103
process.kill()
102104

103105
app_processes.clear()

0 commit comments

Comments
 (0)