Merge pull request #2211 from dearchap/issue_2208

Fix:(issue_2208) Fix local flag

Author: dearchap

command.go

@@ -384,6 +384,21 @@ func (cmd *Command) lookupFlag(name string) Flag {
 	return nil
 }
 
+// this looks up only allowed flags, i.e. local flags for current command
+// or persistent flags from ancestors
+func (cmd *Command) lookupAppliedFlag(name string) Flag {
+	for _, f := range cmd.appliedFlags {
+		if slices.Contains(f.Names(), name) {
+			tracef("appliedFlag found for name %[1]q (cmd=%[2]q)", name, cmd.Name)
+			return f
+		}
+	}
+
+	tracef("lookupAppliedflag NOT found for name %[1]q (cmd=%[2]q)", name, cmd.Name)
+	cmd.onInvalidFlag(context.TODO(), name)
+	return nil
+}
+
 func (cmd *Command) checkRequiredFlag(f Flag) (bool, string) {
 	if rf, ok := f.(RequiredFlag); ok && rf.IsRequired() {
 		flagName := f.Names()[0]

command_parse.go

@@ -144,7 +144,7 @@ func (cmd *Command) parseFlags(args Args) (Args, error) {
 
 		tracef("flagName:2 (fName=%[1]q) (fVal=%[2]q)", flagName, flagVal)
 
-		f := cmd.lookupFlag(flagName)
+		f := cmd.lookupAppliedFlag(flagName)
 		// found a flag matching given flagName
 		if f != nil {
 			tracef("Trying flag type (fName=%[1]q) (type=%[2]T)", flagName, f)

command_test.go

@@ -3024,6 +3024,34 @@ func TestFlagAction(t *testing.T) {
 	}
 }
 
+func TestLocalFlagError(t *testing.T) {
+	var topInt int64
+
+	cmd := &Command{
+		Flags: []Flag{
+			&Int64Flag{
+				Name:        "cmdFlag",
+				Destination: &topInt,
+				Local:       true,
+			},
+		},
+		Commands: []*Command{
+			{
+				Name: "subcmd",
+			},
+		},
+	}
+
+	err := cmd.Run(buildTestContext(t), []string{
+		"app",
+		"subcmd",
+		"--cmdFlag", "11",
+	})
+
+	assert.Error(t, err)
+	assert.Contains(t, err.Error(), "flag provided but not defined: -cmdFlag")
+}
+
 func TestPersistentFlag(t *testing.T) {
 	var topInt, topPersistentInt, subCommandInt, appOverrideInt int64
 	var appFlag string