Merge pull request #1705 from avorima/add-makezero-linter

Add makezero linter

Author: dearchap

.golangci.yaml

@@ -1,4 +1,5 @@
 # https://golangci-lint.run/usage/configuration/
 linters:
   enable:
-    - misspell
+    - makezero
+    - misspell

errors.go

@@ -41,9 +41,7 @@ func (m *multiError) Error() string {
 // Errors returns a copy of the errors slice
 func (m *multiError) Errors() []error {
 	errs := make([]error, len(*m))
-	for _, err := range *m {
-		errs = append(errs, err)
-	}
+	copy(errs, *m)
 	return errs
 }
 

errors_test.go

@@ -159,3 +159,13 @@ func TestHandleExitCoder_MultiErrorWithFormat(t *testing.T) {
 	expect(t, called, true)
 	expect(t, ErrWriter.(*bytes.Buffer).String(), "This the format: err1\nThis the format: err2\n")
 }
+
+func TestMultiErrorErrorsCopy(t *testing.T) {
+	errList := []error{
+		errors.New("foo"),
+		errors.New("bar"),
+		errors.New("baz"),
+	}
+	me := newMultiError(errList...)
+	expect(t, errList, me.Errors())
+}