Merge pull request #2171 from dearchap/issue_2169

Fix:(issue_2169) Allow trim space for string slice flags

Author: dearchap

command_test.go

@@ -4311,6 +4311,9 @@ func TestCommandReadArgsFromStdIn(t *testing.T) {
 				},
 				&StringSliceFlag{
 					Name: "ssf",
+					Config: StringConfig{
+						TrimSpace: true,
+					},
 				},
 			}
 

flag_slice_base.go

@@ -47,8 +47,21 @@ func (i *SliceBase[T, C, VC]) Set(value string) error {
 		return nil
 	}
 
+	trimSpace := true
+	// hack. How do we know if we should trim spaces?
+	// it makes sense only for string slice flags which have
+	// an option to not trim spaces. So by default we trim spaces
+	// otherwise we let the underlying value type handle it.
+	var t T
+	if reflect.TypeOf(t).Kind() == reflect.String {
+		trimSpace = false
+	}
+
 	for _, s := range flagSplitMultiValues(value) {
-		if err := i.value.Set(strings.TrimSpace(s)); err != nil {
+		if trimSpace {
+			s = strings.TrimSpace(s)
+		}
+		if err := i.value.Set(s); err != nil {
 			return err
 		}
 		*i.slice = append(*i.slice, i.value.Get().(T))

flag_test.go

@@ -350,6 +350,12 @@ func TestFlagsFromEnv(t *testing.T) {
 			output: []string{"foo", "bar"},
 			fl:     &StringSliceFlag{Name: "names", Sources: EnvVars("NAMES"), Config: StringConfig{TrimSpace: true}},
 		},
+		{
+			name:   "StringSliceFlag valid without TrimSpace",
+			input:  "foo , bar ",
+			output: []string{"foo ", " bar "},
+			fl:     &StringSliceFlag{Name: "names", Sources: EnvVars("NAMES")},
+		},
 
 		{
 			name:   "StringMapFlag valid",