Fix compiler warnings for TCPServer class

vdm-dev · vdm-dev · commit 590162dd6abb · 2024-12-09T16:23:00.000+04:00
diff --git a/src/comm/tcp_server.cpp b/src/comm/tcp_server.cpp
@@ -64,8 +64,8 @@ TCPServer::~TCPServer()
 
 void TCPServer::init()
 {
-  int err = (listen_fd_ = socket(AF_INET, SOCK_STREAM, 0));
-  if (err == -1)
+  socket_t err = (listen_fd_ = socket(AF_INET, SOCK_STREAM, 0));
+  if (err < 0)
   {
     throw std::system_error(std::error_code(errno, std::generic_category()), "Failed to create socket endpoint");
   }
@@ -100,7 +100,8 @@ void TCPServer::shutdown()
   }
 #endif
 
-  struct sockaddr_in address = { 0 };
+  struct sockaddr_in address;
+  memset(&address, 0, sizeof(address));
   address.sin_family = AF_INET;
   address.sin_addr.s_addr = htonl(INADDR_LOOPBACK);
   address.sin_port = htons(port_);

Original file line number	Diff line number	Diff line change
`@@ -64,8 +64,8 @@ TCPServer::~TCPServer()`
`64`	`64`
`65`	`65`	`void TCPServer::init()`
`66`	`66`	`{`
`67`		`- int err = (listen_fd_ = socket(AF_INET, SOCK_STREAM, 0));`
`68`		`- if (err == -1)`
	`67`	`+ socket_t err = (listen_fd_ = socket(AF_INET, SOCK_STREAM, 0));`
	`68`	`+ if (err < 0)`
`69`	`69`	`{`
`70`	`70`	`throw std::system_error(std::error_code(errno, std::generic_category()), "Failed to create socket endpoint");`
`71`	`71`	`}`
`@@ -100,7 +100,8 @@ void TCPServer::shutdown()`
`100`	`100`	`}`
`101`	`101`	`#endif`
`102`	`102`
`103`		`- struct sockaddr_in address = { 0 };`
	`103`	`+ struct sockaddr_in address;`
	`104`	`+ memset(&address, 0, sizeof(address));`
`104`	`105`	`address.sin_family = AF_INET;`
`105`	`106`	`address.sin_addr.s_addr = htonl(INADDR_LOOPBACK);`
`106`	`107`	`address.sin_port = htons(port_);`