some renaming

Author: robamu

src/spacepackets/ecss/pus_1_verification.py

@@ -69,7 +69,7 @@ def __repr__(self):
 
 
 @dataclass
-class VerificationManagedParams:
+class ManagedParamsVerification:
     bytes_step_id: int = 1
     bytes_err_code: int = 1
 
@@ -161,15 +161,15 @@ def __empty(cls) -> Service1Tm:
         return cls(apid=0, subservice=Subservice.INVALID, timestamp=b"")
 
     @classmethod
-    def from_tm(cls, tm: PusTm, verif_params: VerificationManagedParams) -> Service1Tm:
+    def from_tm(cls, tm: PusTm, verif_params: ManagedParamsVerification) -> Service1Tm:
         service_1_tm = cls.__empty()
         service_1_tm.pus_tm = tm
         cls._unpack_raw_tm(service_1_tm, verif_params)
         return service_1_tm
 
     @classmethod
     def unpack(
-        cls, data: bytes, managed_params: ManagedParams, verif_params: VerificationManagedParams
+        cls, data: bytes, managed_params: ManagedParams, verif_params: ManagedParamsVerification
     ) -> Service1Tm:
         """Parse a service 1 telemetry packet.
 
@@ -218,7 +218,7 @@ def source_data(self) -> bytes:
         return self.pus_tm.source_data
 
     @classmethod
-    def _unpack_raw_tm(cls, instance: Service1Tm, params: VerificationManagedParams) -> None:
+    def _unpack_raw_tm(cls, instance: Service1Tm, params: ManagedParamsVerification) -> None:
         tm_data = instance.pus_tm.tm_data
         if len(tm_data) < 4:
             raise TmSrcDataTooShortError(4, len(tm_data))
@@ -228,7 +228,7 @@ def _unpack_raw_tm(cls, instance: Service1Tm, params: VerificationManagedParams)
         else:
             instance._unpack_success_verification(params)
 
-    def _unpack_failure_verification(self, unpack_cfg: VerificationManagedParams) -> None:
+    def _unpack_failure_verification(self, unpack_cfg: ManagedParamsVerification) -> None:
         """Handle parsing a verification failure packet, subservice ID 2, 4, 6 or 8"""
         tm_data = self.pus_tm.tm_data
         subservice = self.pus_tm.subservice
@@ -249,7 +249,7 @@ def _unpack_failure_verification(self, unpack_cfg: VerificationManagedParams) ->
             tm_data[current_idx:], unpack_cfg.bytes_err_code, len(tm_data) - current_idx
         )
 
-    def _unpack_success_verification(self, unpack_cfg: VerificationManagedParams) -> None:
+    def _unpack_success_verification(self, unpack_cfg: ManagedParamsVerification) -> None:
         if self.pus_tm.subservice == Subservice.TM_STEP_SUCCESS:
             try:
                 self._verif_params.step_id = StepId.unpack(

tests/ecss/test_srv1.py

@@ -10,7 +10,7 @@
     Service1Tm,
     StepId,
     Subservice,
-    VerificationManagedParams,
+    ManagedParamsVerification,
     VerificationParams,
     create_acceptance_failure_tm,
     create_acceptance_success_tm,
@@ -46,7 +46,7 @@ def test_basic(self):
         self.assertEqual(self.srv1_tm.error_code, None)
 
     def test_other_ctor(self):
-        srv1_tm = Service1Tm.from_tm(self.srv1_tm.pus_tm, VerificationManagedParams())
+        srv1_tm = Service1Tm.from_tm(self.srv1_tm.pus_tm, ManagedParamsVerification())
         self.assertEqual(srv1_tm, self.srv1_tm)
 
     def test_failure_notice(self):
@@ -148,7 +148,7 @@ def _test_srv_1_success_tm(
         self.assertEqual(srv_1_tm.tc_req_id.tc_psc, pus_tc.packet_seq_control)
         srv_1_tm_raw = srv_1_tm.pack()
         srv_1_tm_unpacked = Service1Tm.unpack(
-            srv_1_tm_raw, ManagedParams(len(TEST_STAMP)), VerificationManagedParams()
+            srv_1_tm_raw, ManagedParams(len(TEST_STAMP)), ManagedParamsVerification()
         )
         self.assertEqual(srv_1_tm_unpacked.tc_req_id.tc_packet_id.raw(), pus_tc.packet_id.raw())
         self.assertEqual(srv_1_tm_unpacked.tc_req_id.tc_psc.raw(), pus_tc.packet_seq_control.raw())
@@ -220,7 +220,7 @@ def _test_srv_1_failure_comparison_helper(
         self.assertEqual(srv_1_tm.tc_req_id.tc_packet_id, pus_tc.packet_id)
         self.assertEqual(srv_1_tm.tc_req_id.tc_psc, pus_tc.packet_seq_control)
         srv_1_tm_raw = srv_1_tm.pack()
-        unpack_params = VerificationManagedParams()
+        unpack_params = ManagedParamsVerification()
         if failure_notice is not None:
             unpack_params.bytes_err_code = failure_notice.code.len()
         if step_id is not None: