Clippy

Author: usbalbin

probe-plotter-tools/src/main.rs

@@ -8,13 +8,11 @@ use shunting::{MathContext, RPNExpr, ShuntingParser};
 
 fn main() {
     let elf_path = std::env::args()
-        .skip(1)
-        .next()
+        .nth(1)
         .expect("Usage: \nprobe-plotter /path/to/elf chip");
 
     let target = std::env::args()
-        .skip(2)
-        .next()
+        .nth(2)
         .unwrap_or_else(|| "stm32g474retx".to_owned());
     let mut session = probe_rs::Session::auto_attach(target, Default::default()).unwrap();
     let mut core = session.core(0).unwrap();

probe-plotter/src/lib.rs

@@ -31,18 +31,20 @@ pub struct Metric<T> {
 /// This library currently uses the `shunting` library for parsing the expression for the formula.
 /// Check the documentation for that lib for the syntax to use.
 impl<T> Metric<T> {
+    /// # Safety
+    /// Internal use only by [make_metric]
     pub const unsafe fn new(x: *mut T) -> Self {
         Metric { x }
     }
 
     pub fn set(&mut self, x: T) {
         unsafe {
             // TODO: Is volatile the right thing to use here?
-            (self.x as *mut T).write_volatile(x);
+            self.x.write_volatile(x);
         }
     }
 
     pub fn get(&mut self) -> T {
-        unsafe { (self.x as *mut T).read_volatile() }
+        unsafe { self.x.read_volatile() }
     }
 }