Skip to content

Commit d98590a

Browse files
Fix PHP Volume (#842)
<!-- Thanks for the contribution, this is awesome. --> # PR Details ## Description PR #836 broke docker compose by accidentally removing volume tag for PHP service. This PR undoes that change <!--- Describe your changes in detail --> ## Related GitHub Issue <!--- This project only accepts pull requests related to open GitHub issues or Jira Keys --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please DO NOT name partially fixed issues, instead open an issue specific to this fix --> <!--- Please link to the issue here: --> ## Related Jira Key <!-- e.g. CAR-123 --> ## Motivation and Context PR #836 broke docker compose by accidentally removing volume tag for PHP service. This PR undoes that change <!--- Why is this change required? What problem does it solve? --> ## How Has This Been Tested? Dev Container <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Defect fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have added any new packages to the sonar-scanner.properties file - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have read the [**CONTRIBUTING**](https://github.com/usdot-fhwa-stol/carma-platform/blob/develop/Contributing.md) document. - [ ] I have added tests to cover my changes. - [x] All new and existing tests passed.
1 parent 2b75f6c commit d98590a

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

configuration/docker-compose.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ services:
4242
tty: true
4343
environment:
4444
- TZ=${TZ:-America/New_York}
45+
volumes
4546
- ssl-certs-volume:/etc/apache2/ssl:ro
4647

4748

0 commit comments

Comments
 (0)