use short array syntax

Author: Douglas Greenshields

Command/TestFormattingCommand.php

@@ -62,7 +62,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         );
 
         $renderer = $this->getContainer()->get('markup_addressing.address.renderer');
-        $renderedLines = explode("\n", $renderer->render($address, array('format' => 'plaintext')));
+        $renderedLines = explode("\n", $renderer->render($address, ['format' => 'plaintext']));
 
         $output->writeln('<info>Formatted address:</info>');
         foreach ($renderedLines as $line) {

DependencyInjection/Compiler/RegisterAddressFormatExtensionsPass.php

@@ -24,7 +24,7 @@ public function process(ContainerBuilder $container)
                 if (!isset($attributes['alias'])) {
                     continue;
                 }
-                $provider->addMethodCall('registerExtension', array($attributes['alias'], new Reference($id)));
+                $provider->addMethodCall('registerExtension', [$attributes['alias'], new Reference($id)]);
             }
         }
     }

DependencyInjection/Compiler/RegisterAddressNodeProvidersPass.php

@@ -24,7 +24,7 @@ public function process(ContainerBuilder $container)
                 if (!isset($attributes['alias'])) {
                     continue;
                 }
-                $fac->addMethodCall('registerProvider', array($attributes['alias'], new Reference($id)));
+                $fac->addMethodCall('registerProvider', [$attributes['alias'], new Reference($id)]);
             }
         }
     }

DependencyInjection/MarkupAddressingExtension.php

@@ -53,7 +53,7 @@ private function loadCountryPostalCodeOverrides(array $config, ContainerBuilder
             return;
         }
         $overridesProvider = $container->getDefinition('markup_addressing.country_regex_override_provider');
-        $overridesProvider->addMethodCall('setOverrideRegexes', array($config['country_postal_code_regex_overrides']));
+        $overridesProvider->addMethodCall('setOverrideRegexes', [$config['country_postal_code_regex_overrides']]);
     }
 
     /**

README.md

@@ -21,10 +21,10 @@ Add MarkupAddressingBundle to your AppKernel.php:
 ```php
     public function registerBundles()
     {
-        $bundles = array(
+        $bundles = [
             ...
             new Markup\AddressingBundle\MarkupAddressingBundle(),
-        );
+        ];
         ...
     }
 ```
@@ -42,7 +42,7 @@ Simple usage example:
 ```php
     $renderer = $this->get('markup_addressing.address.renderer');
     $address = new MyAddressAdapter($myAddress); //MyAddressAdapter here wraps a different address definition and makes it implement Markup\Addressing\AddressInterface
-    echo $renderer->render($address, array('format' => 'plaintext'));
+    echo $renderer->render($address, ['format' => 'plaintext']);
 ```
 
 This would echo out an address, formatted correctly according to the country, using plaintext.

Tests/Validator/CountryRegexOverrideProviderTest.php

@@ -8,7 +8,7 @@ class CountryRegexOverrideProviderTest extends \PHPUnit_Framework_TestCase
 {
     protected function setUp()
     {
-        $this->overrides = array('IT' => '/^\d{5}$/');
+        $this->overrides = ['IT' => '/^\d{5}$/'];
         $this->provider = new CountryRegexOverrideProvider($this->overrides);
     }
 

Tests/Validator/MultipleRegexValidatorTest.php

@@ -30,7 +30,7 @@ public function testIsConstraintValidator()
     public function testPassingPostalCode()
     {
         $postalCode = '123-456';
-        $patterns = array('/^\d{3}\-\d{3}$/', '/^\d{5}$/');
+        $patterns = ['/^\d{3}\-\d{3}$/', '/^\d{5}$/'];
         $constraint = new MultipleRegexConstraint();
         $constraint->patterns = $patterns;
         $this->context
@@ -42,7 +42,7 @@ public function testPassingPostalCode()
     public function testFailingPostalCode()
     {
         $postalCode = '123';
-        $patterns = array('/^[A-Z]{4}$/');
+        $patterns = ['/^[A-Z]{4}$/'];
         $constraint = new MultipleRegexConstraint();
         $constraint->patterns = $patterns;
         $this->context

Tests/Validator/RegionValidatorTest.php

@@ -54,13 +54,13 @@ public function testValidationCases($country, $region, $expectedPass)
 
     public function cases()
     {
-        return array(
-            array('FR', 'Île de France', true),
-            array('US', 'NY', true),
-            array('US', 'New York', false),
-            array('CA', 'ON', true),
-            array('US', 'Ontario', false),
-        );
+        return [
+            ['FR', 'Île de France', true],
+            ['US', 'NY', true],
+            ['US', 'New York', false],
+            ['CA', 'ON', true],
+            ['US', 'Ontario', false],
+        ];
     }
 
     public function testNonAbbreviationsPassWhenNotStrict()

Validator/CountryRegexOverrideProvider.php

@@ -17,7 +17,7 @@ class CountryRegexOverrideProvider
     /**
      * @param array $overrideRegexes
      */
-    public function __construct(array $overrideRegexes = array())
+    public function __construct(array $overrideRegexes = [])
     {
         $this->setOverrideRegexes($overrideRegexes);
     }
@@ -39,7 +39,7 @@ public function getOverrideFor($country)
      * @param array $overrideRegexes
      * @return self
      */
-    public function setOverrideRegexes(array $overrideRegexes = array())
+    public function setOverrideRegexes(array $overrideRegexes = [])
     {
         $this->overrideRegexes = $overrideRegexes;
 

Validator/LocalizedPostalCodeValidatorClosureProvider.php

@@ -44,7 +44,7 @@ public function fetchValidatorForCountry($country, $message = null)
         $override = $this->countryRegexOverrideProvider->getOverrideFor($country);
         if ($override) {
             if (!is_array($override)) {
-                $override = array($override);
+                $override = [$override];
             }
 
             return $this->createValidatorClosureForConstraint($this->getMultipleRegexConstraint($override, $message));
@@ -84,19 +84,19 @@ public function fetchValidatorForCountry($country, $message = null)
                 return $this->createValidatorClosureForConstraint($this->getFixedLengthDigitConstraint(5, $message));
 
             case 'NL':
-                return $this->createValidatorClosureForConstraint($this->getMultipleRegexConstraint(array('/^\d{4}\s[A-Z]{2}$/'), $message));
+                return $this->createValidatorClosureForConstraint($this->getMultipleRegexConstraint(['/^\d{4}\s[A-Z]{2}$/'], $message));
 
             case 'PL':
-                return $this->createValidatorClosureForConstraint($this->getMultipleRegexConstraint(array('/^\d{2}\-\d{3}$/'), $message));
+                return $this->createValidatorClosureForConstraint($this->getMultipleRegexConstraint(['/^\d{2}\-\d{3}$/'], $message));
 
             case 'PT':
-                return $this->createValidatorClosureForConstraint($this->getMultipleRegexConstraint(array('/^\d{4}\-\d{3}$/'), $message));
+                return $this->createValidatorClosureForConstraint($this->getMultipleRegexConstraint(['/^\d{4}\-\d{3}$/'], $message));
 
             case 'CA':
-                return $this->createValidatorClosureForConstraint($this->getMultipleRegexConstraint(array('/^[A-Z][0-9][A-Z] [0-9][A-Z][0-9]$/'), $message));
+                return $this->createValidatorClosureForConstraint($this->getMultipleRegexConstraint(['/^[A-Z][0-9][A-Z] [0-9][A-Z][0-9]$/'], $message));
 
             case 'US':
-                return $this->createValidatorClosureForConstraint($this->getMultipleRegexConstraint(array('/^[0-9]{5}$/', '/^[0-9]{5}\-[0-9]{4}$/'), $message));
+                return $this->createValidatorClosureForConstraint($this->getMultipleRegexConstraint(['/^[0-9]{5}$/', '/^[0-9]{5}\-[0-9]{4}$/'], $message));
 
             default:
                 return null;