[SoapBundle] Simplified conditional statement

francisbesset · francisbesset · commit 1b4e262c608a · 2013-12-08T00:25:20.000+01:00
diff --git a/src/BeSimple/SoapBundle/ServiceBinding/RpcLiteralRequestMessageBinder.php b/src/BeSimple/SoapBundle/ServiceBinding/RpcLiteralRequestMessageBinder.php
@@ -112,9 +112,8 @@ protected function checkComplexType($phpType, $message)
                 $value = $this->processType($type->getType(), $value);
 
                 $messageBinder->writeProperty($property, $value);
-            }
-
-            if (!$type->isNillable() && null === $value) {
+            } elseif (!$type->isNillable()) {
+                // @TODO use xmlType instead of phpType
                 throw new \SoapFault('SOAP_ERROR_COMPLEX_TYPE', sprintf('"%s:%s" cannot be null.', ucfirst($phpType), $type->getName()));
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -112,9 +112,8 @@ protected function checkComplexType($phpType, $message)`
`112`	`112`	`$value = $this->processType($type->getType(), $value);`
`113`	`113`
`114`	`114`	`$messageBinder->writeProperty($property, $value);`
`115`		`- }`
`116`		`-`
`117`		`- if (!$type->isNillable() && null === $value) {`
	`115`	`+ } elseif (!$type->isNillable()) {`
	`116`	`+ // @TODO use xmlType instead of phpType`
`118`	`117`	`throw new \SoapFault('SOAP_ERROR_COMPLEX_TYPE', sprintf('"%s:%s" cannot be null.', ucfirst($phpType), $type->getName()));`
`119`	`118`	`}`
`120`	`119`	`}`