[SoapClient] Renamed proxy_user to proxy_login option to keep compatibility with SoapClient of PHP

Author: francisbesset

src/BeSimple/SoapClient/Curl.php

@@ -90,8 +90,8 @@ public function __construct(array $options = array(), $followLocationMaxRedirect
 
             curl_setopt($this->ch, CURLOPT_PROXY, $proxyHost);
 
-            if ($proxyHost && isset($options['proxy_user'])) {
-                curl_setopt($this->ch, CURLOPT_PROXYUSERPWD, $options['proxy_user'].':'.$options['proxy_pass']);
+            if (false !== $proxyHost && isset($options['proxy_login'])) {
+                curl_setopt($this->ch, CURLOPT_PROXYUSERPWD, $options['proxy_login'].':'.$options['proxy_password']);
             }
         }
 

src/BeSimple/SoapClient/SoapClientBuilder.php

@@ -175,19 +175,19 @@ public function withDigestAuthentication($certificate, $passphrase = null)
      *
      * @param string $host     Host
      * @param int    $port     Port
-     * @param string $username Username
+     * @param string $login    Login
      * @param string $password Password
      *
      * @return \BeSimple\SoapClient\SoapClientBuilder
      */
-    public function withProxy($host, $port, $user = null, $pass = null)
+    public function withProxy($host, $port, $login = null, $password = null)
     {
         $this->soapOptions['proxy_host'] = $host;
         $this->soapOptions['proxy_port'] = $port;
 
-        if ($user) {
-            $this->soapOptions['proxy_user'] = $user;
-            $this->soapOptions['proxy_pass'] = $pass;
+        if ($login) {
+            $this->soapOptions['proxy_login'] = $login;
+            $this->soapOptions['proxy_password'] = $password;
         }
 
         return $this;

src/BeSimple/SoapClient/Tests/SoapClientBuilderTest.php

@@ -95,7 +95,7 @@ public function testWithProxy()
         $this->assertEquals($this->mergeOptions(array('proxy_host' => 'localhost', 'proxy_port' => 8080)), $builder->getSoapOptions());
 
         $builder->withProxy('127.0.0.1', 8585, 'foo', 'bar');
-        $this->assertEquals($this->mergeOptions(array('proxy_host' => '127.0.0.1', 'proxy_port' => 8585, 'proxy_user' => 'foo', 'proxy_pass' => 'bar')), $builder->getSoapOptions());
+        $this->assertEquals($this->mergeOptions(array('proxy_host' => '127.0.0.1', 'proxy_port' => 8585, 'proxy_login' => 'foo', 'proxy_password' => 'bar')), $builder->getSoapOptions());
     }
 
     public function testCreateWithDefaults()