fix: prevent ttl being a negative number (and therefore in the future)

gsdevme · gsdevme · commit c727ead1a82f · 2020-07-09T17:53:47.000+01:00
diff --git a/Repository/JobLogRepository.php b/Repository/JobLogRepository.php
@@ -162,11 +162,11 @@ public function findJobLog(string $uuid): ?JobLog
     }
 
     /**
-     * Removes all jobs older than ($this->ttl - 86400 seconds) from all secondary indexes
+     * Removes all jobs older than ($this->ttl) from all secondary indexes
      */
     public function removeExpiredJobs(): void
     {
-        $interval = new \DateInterval(sprintf('PT%sS', $this->ttl - 86400));
+        $interval = new \DateInterval(sprintf('PT%sS', $this->ttl));
         $before = (new \DateTime('now'))->sub($interval)->format('U');
 
         $qb = $this->getEntityManager()->createQueryBuilder();

Original file line number	Diff line number	Diff line change
`@@ -162,11 +162,11 @@ public function findJobLog(string $uuid): ?JobLog`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`/**`
`165`		`- * Removes all jobs older than ($this->ttl - 86400 seconds) from all secondary indexes`
	`165`	`+ * Removes all jobs older than ($this->ttl) from all secondary indexes`
`166`	`166`	`*/`
`167`	`167`	`public function removeExpiredJobs(): void`
`168`	`168`	`{`
`169`		`- $interval = new \DateInterval(sprintf('PT%sS', $this->ttl - 86400));`
	`169`	`+ $interval = new \DateInterval(sprintf('PT%sS', $this->ttl));`
`170`	`170`	`$before = (new \DateTime('now'))->sub($interval)->format('U');`
`171`	`171`
`172`	`172`	`$qb = $this->getEntityManager()->createQueryBuilder();`