Skip to content

Commit 63b5e11

Browse files
astalkershieldo
authored andcommitted
fix(cache): Dont save to cache when data invalid (#31)
1 parent dc29e5d commit 63b5e11

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/Contentful.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -586,8 +586,12 @@ function ($builtResponse) use ($test) {
586586
//save into cache
587587
if ($api !== self::CONTENT_MANAGEMENT_API) {
588588
$isSuccessResponseData = !$unavailableException && $isValidResponse;
589-
$writeCacheItem->set($responseJson);
590-
$writeCache->save($writeCacheItem);
589+
590+
if ($isSuccessResponseData || $this->cacheFailResponses) {
591+
$writeCacheItem->set($responseJson);
592+
$writeCache->save($writeCacheItem);
593+
}
594+
591595
if (!isset($fallbackCacheItem)) {
592596
/**
593597
* @var CacheItemInterface $fallbackCacheItem

0 commit comments

Comments
 (0)