feat: update instance profile to use admin user instead of initialized flag

- Changed InstanceProfile to include admin user field
- Updated GetInstanceProfile method to retrieve admin user
- Modified related tests to reflect changes in admin user retrieval
- Removed owner cache logic and tests, introducing new admin cache tests

Author: boojack

proto/api/v1/instance_service.proto

@@ -2,6 +2,7 @@ syntax = "proto3";
 
 package memos.api.v1;
 
+import "api/v1/user_service.proto";
 import "google/api/annotations.proto";
 import "google/api/client.proto";
 import "google/api/field_behavior.proto";
@@ -43,10 +44,9 @@ message InstanceProfile {
   // Instance URL is the URL of the instance.
   string instance_url = 6;
 
-  // Indicates if the instance has completed first-time setup.
-  // When false, the instance requires initialization (creating the first admin account).
-  // This follows the pattern used by other self-hosted platforms for setup workflows.
-  bool initialized = 7;
+  // The first administrator who set up this instance.
+  // When null, instance requires initial setup (creating the first admin account).
+  User admin = 7;
 }
 
 // Request for instance profile.

proto/gen/api/v1/instance_service.pb.go

@@ -2141,12 +2141,12 @@ components:
                 instanceUrl:
                     type: string
                     description: Instance URL is the URL of the instance.
-                initialized:
-                    type: boolean
+                admin:
+                    allOf:
+                        - $ref: '#/components/schemas/User'
                     description: |-
-                        Indicates if the instance has completed first-time setup.
-                         When false, the instance requires initialization (creating the first admin account).
-                         This follows the pattern used by other self-hosted platforms for setup workflows.
+                        The first administrator who set up this instance.
+                         When null, instance requires initial setup (creating the first admin account).
             description: Instance profile message containing basic instance information.
         InstanceSetting:
             type: object

proto/gen/openapi.yaml

@@ -3,7 +3,6 @@ package v1
 import (
 	"context"
 	"fmt"
-	"sync"
 
 	"github.com/pkg/errors"
 	"google.golang.org/grpc/codes"
@@ -16,16 +15,16 @@ import (
 
 // GetInstanceProfile returns the instance profile.
 func (s *APIV1Service) GetInstanceProfile(ctx context.Context, _ *v1pb.GetInstanceProfileRequest) (*v1pb.InstanceProfile, error) {
-	owner, err := s.GetInstanceOwner(ctx)
+	admin, err := s.GetInstanceAdmin(ctx)
 	if err != nil {
-		return nil, status.Errorf(codes.Internal, "failed to get instance owner: %v", err)
+		return nil, status.Errorf(codes.Internal, "failed to get instance admin: %v", err)
 	}
 
 	instanceProfile := &v1pb.InstanceProfile{
 		Version:     s.Profile.Version,
 		Demo:        s.Profile.Demo,
 		InstanceUrl: s.Profile.InstanceURL,
-		Initialized: owner != nil,
+		Admin:       admin, // nil when not initialized
 	}
 	return instanceProfile, nil
 }
@@ -270,48 +269,17 @@ func convertInstanceMemoRelatedSettingToStore(setting *v1pb.InstanceSetting_Memo
 	}
 }
 
-var (
-	ownerCache      *v1pb.User
-	ownerCacheMutex sync.RWMutex
-)
-
-func (s *APIV1Service) GetInstanceOwner(ctx context.Context) (*v1pb.User, error) {
-	// Try read lock first for cache hit
-	ownerCacheMutex.RLock()
-	if ownerCache != nil {
-		defer ownerCacheMutex.RUnlock()
-		return ownerCache, nil
-	}
-	ownerCacheMutex.RUnlock()
-
-	// Upgrade to write lock to populate cache
-	ownerCacheMutex.Lock()
-	defer ownerCacheMutex.Unlock()
-
-	// Double-check after acquiring write lock
-	if ownerCache != nil {
-		return ownerCache, nil
-	}
-
+func (s *APIV1Service) GetInstanceAdmin(ctx context.Context) (*v1pb.User, error) {
 	adminUserType := store.RoleAdmin
 	user, err := s.Store.GetUser(ctx, &store.FindUser{
 		Role: &adminUserType,
 	})
 	if err != nil {
-		return nil, errors.Wrapf(err, "failed to find owner")
+		return nil, errors.Wrapf(err, "failed to find admin")
 	}
 	if user == nil {
 		return nil, nil
 	}
 
-	ownerCache = convertUserFromStore(user)
-	return ownerCache, nil
-}
-
-// ClearInstanceOwnerCache clears the cached instance owner.
-// This should be called when an admin user is created or when the owner changes.
-func (*APIV1Service) ClearInstanceOwnerCache() {
-	ownerCacheMutex.Lock()
-	defer ownerCacheMutex.Unlock()
-	ownerCache = nil
+	return convertUserFromStore(user), nil
 }

server/router/api/v1/instance_service.go

@@ -9,7 +9,7 @@ import (
 	v1pb "github.com/usememos/memos/proto/gen/api/v1"
 )
 
-func TestInstanceOwnerCache(t *testing.T) {
+func TestInstanceAdminRetrieval(t *testing.T) {
 	ctx := context.Background()
 
 	t.Run("Instance becomes initialized after first admin user is created", func(t *testing.T) {
@@ -20,7 +20,7 @@ func TestInstanceOwnerCache(t *testing.T) {
 		// Verify instance is not initialized initially
 		profile1, err := ts.Service.GetInstanceProfile(ctx, &v1pb.GetInstanceProfileRequest{})
 		require.NoError(t, err)
-		require.False(t, profile1.Initialized, "Instance should not be initialized before first admin user")
+		require.Nil(t, profile1.Admin, "Instance should not be initialized before first admin user")
 
 		// Create the first admin user
 		user, err := ts.CreateHostUser(ctx, "admin")
@@ -30,29 +30,25 @@ func TestInstanceOwnerCache(t *testing.T) {
 		// Verify instance is now initialized
 		profile2, err := ts.Service.GetInstanceProfile(ctx, &v1pb.GetInstanceProfileRequest{})
 		require.NoError(t, err)
-		require.True(t, profile2.Initialized, "Instance should be initialized after first admin user is created")
+		require.NotNil(t, profile2.Admin, "Instance should be initialized after first admin user is created")
+		require.Equal(t, user.Username, profile2.Admin.Username)
 	})
 
-	t.Run("ClearInstanceOwnerCache works correctly", func(t *testing.T) {
+	t.Run("Admin retrieval is cached by Store layer", func(t *testing.T) {
 		// Create test service
 		ts := NewTestService(t)
 		defer ts.Cleanup()
 
 		// Create admin user
-		_, err := ts.CreateHostUser(ctx, "admin")
-		require.NoError(t, err)
-
-		// Verify initialized
-		profile1, err := ts.Service.GetInstanceProfile(ctx, &v1pb.GetInstanceProfileRequest{})
+		user, err := ts.CreateHostUser(ctx, "admin")
 		require.NoError(t, err)
-		require.True(t, profile1.Initialized)
 
-		// Clear cache
-		ts.Service.ClearInstanceOwnerCache()
-
-		// Should still be initialized (cache is refilled from DB)
-		profile2, err := ts.Service.GetInstanceProfile(ctx, &v1pb.GetInstanceProfileRequest{})
-		require.NoError(t, err)
-		require.True(t, profile2.Initialized)
+		// Multiple calls should return consistent admin user (from cache)
+		for i := 0; i < 5; i++ {
+			profile, err := ts.Service.GetInstanceProfile(ctx, &v1pb.GetInstanceProfileRequest{})
+			require.NoError(t, err)
+			require.NotNil(t, profile.Admin)
+			require.Equal(t, user.Username, profile.Admin.Username)
+		}
 	})
 }

…api/v1/test/instance_owner_cache_test.go …api/v1/test/instance_admin_cache_test.goserver/router/api/v1/test/instance_owner_cache_test.go renamed to server/router/api/v1/test/instance_admin_cache_test.go server/router/api/v1/test/instance_owner_cache_test.go renamed to server/router/api/v1/test/instance_admin_cache_test.go

@@ -31,7 +31,7 @@ func TestGetInstanceProfile(t *testing.T) {
 		require.Equal(t, "http://localhost:8080", resp.InstanceUrl)
 
 		// Instance should not be initialized since no admin users are created
-		require.False(t, resp.Initialized)
+		require.Nil(t, resp.Admin)
 	})
 
 	t.Run("GetInstanceProfile with initialized instance", func(t *testing.T) {
@@ -58,7 +58,8 @@ func TestGetInstanceProfile(t *testing.T) {
 		require.Equal(t, "http://localhost:8080", resp.InstanceUrl)
 
 		// Instance should be initialized since an admin user exists
-		require.True(t, resp.Initialized)
+		require.NotNil(t, resp.Admin)
+		require.Equal(t, hostUser.Username, resp.Admin.Username)
 	})
 }
 
@@ -101,7 +102,7 @@ func TestGetInstanceProfile_Concurrency(t *testing.T) {
 				require.Equal(t, "test-1.0.0", resp.Version)
 				require.True(t, resp.Demo)
 				require.Equal(t, "http://localhost:8080", resp.InstanceUrl)
-				require.True(t, resp.Initialized)
+				require.NotNil(t, resp.Admin)
 			}
 		}
 	})

server/router/api/v1/test/instance_service_test.go

@@ -48,9 +48,6 @@ func NewTestService(t *testing.T) *TestService {
 		MarkdownService: markdownService,
 	}
 
-	// Clear any cached state from previous tests
-	service.ClearInstanceOwnerCache()
-
 	return &TestService{
 		Service: service,
 		Store:   testStore,
@@ -59,9 +56,8 @@ func NewTestService(t *testing.T) *TestService {
 	}
 }
 
-// Cleanup clears caches and closes resources after test.
+// Cleanup closes resources after test.
 func (ts *TestService) Cleanup() {
-	ts.Service.ClearInstanceOwnerCache()
 	ts.Store.Close()
 }
 

server/router/api/v1/test/test_helper.go

@@ -177,12 +177,6 @@ func (s *APIV1Service) CreateUser(ctx context.Context, request *v1pb.CreateUserR
 		return nil, status.Errorf(codes.Internal, "failed to create user: %v", err)
 	}
 
-	// If this is the first admin user being created, clear the owner cache
-	// so that GetInstanceProfile will return initialized=true
-	if roleToAssign == store.RoleAdmin {
-		s.ClearInstanceOwnerCache()
-	}
-
 	return convertUserFromStore(user), nil
 }
 

server/router/api/v1/user_service.go

@@ -22,10 +22,10 @@ const App = () => {
 
   // Redirect to sign up page if instance not initialized (no admin account exists yet)
   useEffect(() => {
-    if (!instanceProfile.initialized) {
+    if (!instanceProfile.admin) {
       navigateTo("/auth/signup");
     }
-  }, [instanceProfile.initialized, navigateTo]);
+  }, [instanceProfile.admin, navigateTo]);
 
   useEffect(() => {
     if (instanceGeneralSetting.additionalStyle) {

web/src/App.tsx

@@ -135,7 +135,7 @@ const SignUp = () => {
         ) : (
           <p className="w-full text-2xl mt-2 text-muted-foreground">Sign up is not allowed.</p>
         )}
-        {!profile.initialized ? (
+        {!profile.admin ? (
           <p className="w-full mt-4 text-sm font-medium text-muted-foreground">{t("auth.host-tip")}</p>
         ) : (
           <p className="w-full mt-4 text-sm">