Skip to content

Commit 4663cd1

Browse files
Merge release/1.38.3 into main branch (#812)
* Adding optional props to Tabs component (#811)
1 parent 0254e05 commit 4663cd1

File tree

5 files changed

+31
-8
lines changed

5 files changed

+31
-8
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@user-interviews/ui-design-system",
3-
"version": "1.38.2",
3+
"version": "1.38.3",
44
"dependencies": {
55
"react-bootstrap": "^2.5.0",
66
"react-loading-skeleton": "^3.1.0",

spec/__snapshots__/Storyshots.test.js.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20626,7 +20626,7 @@ exports[`Storyshots Components/Tabs Controlled 1`] = `
2062620626
>
2062720627
<div>
2062820628
<span
20629-
className="sc-dkPtRN klomrB"
20629+
className="sc-dkPtRN gfzzIq"
2063020630
>
2063120631
<ul
2063220632
className="nav nav-tabs"
@@ -20793,7 +20793,7 @@ exports[`Storyshots Components/Tabs Uncontrolled 1`] = `
2079320793
>
2079420794
<div>
2079520795
<span
20796-
className="sc-dkPtRN klomrB"
20796+
className="sc-dkPtRN gfzzIq"
2079720797
>
2079820798
<ul
2079920799
className="nav nav-tabs"

src/Tabs/Tabs.jsx

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,14 @@ import { StyledTabsWrapper } from './Tabs.styles';
77

88
const Tabs = ({
99
children,
10+
flexWrapUnset,
11+
navItemButtonFullHeight,
1012
...props
1113
}) => (
12-
<StyledTabsWrapper>
14+
<StyledTabsWrapper
15+
flexWrapUnset={flexWrapUnset}
16+
navItemButtonFullHeight={navItemButtonFullHeight}
17+
>
1318
<ReactBootstrapTabs variant="tabs" {...props}>
1419
{children}
1520
</ReactBootstrapTabs>
@@ -21,8 +26,10 @@ export default Tabs;
2126
Tabs.propTypes = {
2227
activeKey: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
2328
defaultActiveKey: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
29+
flexWrapUnset: PropTypes.bool,
2430
id: PropTypes.string.isRequired,
2531
mountOnEnter: PropTypes.bool,
32+
navItemButtonFullHeight: PropTypes.bool,
2633
transition: PropTypes.oneOfType([
2734
PropTypes.oneOf([false]),
2835
PropTypes.elementType,
@@ -34,7 +41,9 @@ Tabs.propTypes = {
3441
Tabs.defaultProps = {
3542
activeKey: undefined,
3643
defaultActiveKey: 1,
44+
flexWrapUnset: false,
3745
mountOnEnter: undefined,
46+
navItemButtonFullHeight: false,
3847
transition: undefined,
3948
unmountOnExit: undefined,
4049
onSelect: undefined,

src/Tabs/Tabs.styles.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,20 @@ const borderWidth = '0.125rem';
66
const fontType30 = '400 0.875rem/1.25rem DM Sans, sans-serif';
77

88
export const StyledTabsWrapper = styled.span`
9+
${({ flexWrapUnset }) => flexWrapUnset && `
10+
.nav {
11+
flex-wrap: nowrap;
12+
}
13+
`}
14+
15+
${({ navItemButtonFullHeight }) => navItemButtonFullHeight && `
16+
.nav-item {
17+
button {
18+
height: calc(100% + ${borderWidth});
19+
}
20+
}
21+
`}
22+
923
.nav-tabs {
1024
border-bottom: ${borderWidth} solid ${colors.UX_GRAY_400};
1125
}

src/Tabs/__snapshots__/Tabs.test.jsx.snap

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Object {
66
"baseElement": <body>
77
<div>
88
<span
9-
class="sc-bdvvtL eGviLc"
9+
class="sc-bdvvtL leMoEj"
1010
>
1111
<ul
1212
class="nav nav-tabs"
@@ -98,7 +98,7 @@ Object {
9898
</body>,
9999
"container": <div>
100100
<span
101-
class="sc-bdvvtL eGviLc"
101+
class="sc-bdvvtL leMoEj"
102102
>
103103
<ul
104104
class="nav nav-tabs"
@@ -247,7 +247,7 @@ Object {
247247
"baseElement": <body>
248248
<div>
249249
<span
250-
class="sc-bdvvtL eGviLc"
250+
class="sc-bdvvtL leMoEj"
251251
>
252252
<ul
253253
class="nav nav-tabs"
@@ -339,7 +339,7 @@ Object {
339339
</body>,
340340
"container": <div>
341341
<span
342-
class="sc-bdvvtL eGviLc"
342+
class="sc-bdvvtL leMoEj"
343343
>
344344
<ul
345345
class="nav nav-tabs"

0 commit comments

Comments
 (0)