Remove default props from func components (#1293)

Author: DevStarks

.eslintrc

@@ -52,6 +52,9 @@
         }],
         "react/no-unescaped-entities": ["error", { "forbid": [">", "}"] }],
         "react/prop-types": [2, { "ignore": ["children"] }],
+        "react/require-default-props": [2, {
+          "functions": "ignore" // ignore rule for function components
+        }],
         "react/react-in-jsx-scope": [0],
         "react/sort-comp": [2, {
             "order": [

src/Accordion/Accordion.tsx

@@ -59,14 +59,4 @@ function Accordion({
   );
 }
 
-Accordion.defaultProps = {
-  activeKey: undefined,
-  alwaysOpen: undefined,
-  as: undefined,
-  defaultActiveKey: undefined,
-  flush: undefined,
-  UNSAFE_className: undefined,
-  onSelect: undefined,
-};
-
 export default Accordion;

src/Accordion/AccordionCollapse.tsx

@@ -49,9 +49,4 @@ function AccordionCollapse({
   );
 }
 
-AccordionCollapse.defaultProps = {
-  variant: undefined,
-  UNSAFE_className: undefined,
-};
-
 export default AccordionCollapse;

src/Accordion/AccordionItem.tsx

@@ -46,10 +46,4 @@ function AccordionItem({
   );
 }
 
-AccordionItem.defaultProps = {
-  variant: undefined,
-  as: undefined,
-  borderless: undefined,
-  UNSAFE_className: undefined,
-};
 export default AccordionItem;

src/Accordion/AccordionToggle.tsx

@@ -45,9 +45,9 @@ type AccordionToggleProps = {
 function AccordionToggle({
   borderBottom,
   children,
-  chevronLateral,
-  chevronLeft,
-  chevronRight,
+  chevronLateral = false,
+  chevronLeft = false,
+  chevronRight = true,
   collapsedText,
   disabled,
   eventKey,
@@ -136,16 +136,4 @@ function AccordionToggle({
   );
 }
 
-AccordionToggle.defaultProps = {
-  chevronLateral: false,
-  chevronLeft: false,
-  chevronRight: true,
-  collapsedText: undefined,
-  disabled: undefined,
-  helperText: undefined,
-  leadingIcon: undefined,
-  title: undefined,
-  UNSAFE_className: undefined,
-};
-
 export default AccordionToggle;

src/Avatar/Avatar.tsx

@@ -17,13 +17,13 @@ type AvatarProps = {
 };
 
 function Avatar({
-  ariaHidden,
+  ariaHidden = false,
   colorId,
   image,
   initials,
-  large,
+  large = false,
   name = '',
-  showAlert,
+  showAlert = false,
   url,
 }: AvatarProps) {
   const [imageLoadFailed, setImageLoadFailed] = useState(false);
@@ -83,14 +83,4 @@ function Avatar({
   );
 }
 
-Avatar.defaultProps = {
-  ariaHidden: false,
-  colorId: undefined,
-  image: undefined,
-  large: false,
-  name: '',
-  showAlert: false,
-  url: undefined,
-};
-
 export default Avatar;

src/CardStack/CardStack.tsx

@@ -35,9 +35,4 @@ function CardStack({
   );
 }
 
-CardStack.defaultProps = {
-  size: undefined,
-  UNSAFE_className: undefined,
-};
-
 export default CardStack;

src/CheckboxButton/CheckboxButton.jsx

@@ -44,7 +44,9 @@ const CheckboxButton = React.forwardRef(({
     />
   );
 });
-
+// The rule is configured to not care about default props for function
+// components but because this is a forwardRef it is being triggered
+/* eslint-disable react/require-default-props */
 CheckboxButton.propTypes = {
   checked: PropTypes.bool,
   className: PropTypes.string,
@@ -59,16 +61,7 @@ CheckboxButton.propTypes = {
   ]),
   onChange: PropTypes.func,
 };
-
-CheckboxButton.defaultProps = {
-  checked: undefined,
-  className: undefined,
-  disabled: undefined,
-  indeterminate: undefined,
-  name: undefined,
-  value: undefined,
-  onChange: undefined,
-};
+/* eslint-enable react/require-default-props */
 
 CheckboxButton.displayName = 'CheckboxButton';
 

src/CheckboxButtonGroup/CheckboxButtonGroup.jsx

@@ -8,11 +8,11 @@ import './CheckboxButtonGroup.scss';
 
 export default function CheckboxButtonGroup({
   children,
-  fullWidth,
+  fullWidth = false,
   id,
-  orientation,
-  parseInput,
-  value,
+  orientation = ORIENTATIONS.ROW,
+  parseInput = (i) => i,
+  value = [],
   onChange,
 }) {
   const row = orientation === ORIENTATIONS.ROW;
@@ -73,11 +73,3 @@ CheckboxButtonGroup.propTypes = {
   ),
   onChange: PropTypes.func,
 };
-
-CheckboxButtonGroup.defaultProps = {
-  fullWidth: false,
-  orientation: ORIENTATIONS.ROW,
-  parseInput: (i) => i,
-  value: [],
-  onChange: undefined,
-};

src/CopyToClipboardButton/CopyToClipboardButton.tsx

@@ -72,10 +72,4 @@ function CopyToClipboardButton({
   );
 }
 
-CopyToClipboardButton.defaultProps = {
-  copyText: '',
-  displayText: undefined,
-  variant: ButtonVariants.NEUTRAL,
-};
-
 export default CopyToClipboardButton;