Skip to content

Commit a3e81b0

Browse files
Merge release/1.32.3 into main branch (#688)
* update build schedule for Chromatic (#681) * Remove percy and cypress (#682) * chromatic build change on push develop (#686) * add ToggleInput (#672)
1 parent 5777eff commit a3e81b0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+517
-3294
lines changed

.github/workflows/chromatic.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
# .github/workflows/chromatic.yml
22

33
# Workflow name
4-
name: 'Chromatic'
4+
name: 'Chromatic build on develop'
55

66
# Event for the workflow
7-
on: push
7+
on:
8+
push:
9+
branches:
10+
- develop
811

912
# List of jobs
1013
jobs:

.github/workflows/percy-nightly-tests.yml

Lines changed: 0 additions & 26 deletions
This file was deleted.

README.md

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -121,15 +121,6 @@ Runs the jest test suite
121121
### `yarn lint`
122122

123123
Runs ESLint to report on any style violations
124-
### Visual testing
125-
126-
1. Join BrowserStack (ask Brian for link)
127-
1. Navigate to this project in percy [here](https://percy.io/f38ae9b9/ui-design-system)
128-
1. Define `PERCY_TOKEN` in shell (the one from ui-design-system project)
129-
1. `npx percy exec -- cypress run`
130-
1. View results in percy.io / console
131-
132-
> Note- we are on the free plan (5k images/month) so be mindful of the limit
133124

134125
### `yarn rs:link`
135126

@@ -142,18 +133,18 @@ Trigger a production build when files are changed.
142133
### `yarn rs:unlink`
143134

144135
Remove symlinked packages.
145-
### Visual testing
146136

147-
1. Join BrowserStack team (ask Brian/Bob for link)
148-
1. Navigate to this project in [Percy](https://percy.io/f38ae9b9/ui-design-system)
137+
## Chromatic visual testing & live feedback
138+
We use [Chromatic](https://www.chromatic.com/) for visual testing and gathering UI feedback.
139+
140+
To join Chromatic for 'ui-design-system', ask Jason for the join link.
149141

150-
## Local setup
151-
1. Define `PERCY_TOKEN` ENV (the one from ui-design-system project found above)
152-
1. Run `yarn storybook` in one tab
153-
1. Run `npx percy exec -- cypress run` in another
154-
1. View results in percy.io & console
142+
If you are a Product Designer or wanting to view changes on a particular feature branch, a developer can provide a link to that specific Chromatic build.
155143

156-
> Note- we are running this once a day via github actions.
144+
If you are a Developer and want to trigger a Chromatic build,
145+
1. Join Chromatic for the 'ui-design-system' (ask Jason for the join link).
146+
2. Go to the Manage tab for 'ui-design-system' > Configure > Find the project token.
147+
3. In your terminal, run `npx chromatic --project-token <projectToken>`. Use this command when you want to create a build and share with a stakeholder to gather UI feedback. You will be able to find the build on the Chromatic builds dashboard. We currently run automatic nightly builds for Chromatic via Github Actions.
157148

158149
## Pull requests
159150

cypress.json

Lines changed: 0 additions & 5 deletions
This file was deleted.

cypress/integration/accordion_spec.js

Lines changed: 0 additions & 49 deletions
This file was deleted.

cypress/integration/alert_spec.js

Lines changed: 0 additions & 50 deletions
This file was deleted.

cypress/integration/avatar_spec.js

Lines changed: 0 additions & 38 deletions
This file was deleted.

cypress/integration/button_spec.js

Lines changed: 0 additions & 48 deletions
This file was deleted.

cypress/integration/card_spec.js

Lines changed: 0 additions & 8 deletions
This file was deleted.

cypress/integration/checkbox_button_spec.js

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)