Skip to content

Commit ef03a1d

Browse files
authored
Improves hover state of tabs to avoid content shifting (#1184)
1 parent 0ed7578 commit ef03a1d

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

package.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,5 +193,9 @@
193193
},
194194
"readme": "https://github.com/user-interviews/ui-design-system#readme",
195195
"homepage": "https://github.com/user-interviews/ui-design-system",
196-
"_id": "@user-interviews/[email protected]"
197-
}
196+
"_id": "@user-interviews/[email protected]",
197+
"volta": {
198+
"node": "18.18.2",
199+
"yarn": "1.22.21"
200+
}
201+
}

scss/colors/synthesis-palette.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ $synth-header-neutral: #fbfbfb;
1919
$synth-page-neutral: #fdfdfd;
2020
$synth-text-neutral: #1b1b1b;
2121
$synth-unselected-neutral: #5b5b5b;
22+
$synth-unselected-tab: #767676;
2223

2324
// main schema - visual hierarchy
2425
$synth-accent-green: #158d71;

scss/css_properties.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@
187187
--synth-page-neutral: #{$synth-page-neutral};
188188
--synth-text-neutral: #{$synth-text-neutral};
189189
--synth-unselected-neutral: #{$synth-unselected-neutral};
190+
--synth-unselected-tab: #{$synth-unselected-tab};
190191
--synth-accent-green: #{$synth-accent-green};
191192
--synth-dark-background-selected-blue: #{$synth-dark-background-selected-blue};
192193
--synth-dark-background-pressed-blue: #{$synth-dark-background-pressed-blue};

src/Tabs/tabs.module.scss

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,17 +41,20 @@
4141

4242
:global(.nav-link),
4343
:global(.nav-link.disabled) {
44-
color: $synth-unselected-neutral;
44+
color: $synth-unselected-tab;
4545
border-bottom: 1px solid $synth-div-stroke-neutral;
4646
position: relative;
4747
margin-bottom: -1px;
4848
}
4949

50+
:global(.nav-link.active) {
51+
font-weight: $synth-font-weight-bold;
52+
}
53+
5054
:global(.nav-link.active),
5155
:global(.nav-link:hover),
5256
:global(.nav-link:active),
5357
:global(.nav-link:focus) {
54-
font-weight: $synth-font-weight-bold;
5558
color: $synth-text-neutral;
5659
border-bottom: 3px solid $synth-indicator-stroke-green;
5760
}

0 commit comments

Comments
 (0)