Optimize performance

Author: usercode

src/AsyncKeyLock/AsyncLock.cs

@@ -12,9 +12,13 @@ public sealed class AsyncLock
     public AsyncLock()
     {
         _syncObj = _waitingWriters;
+
+        _readerReleaserTask = Task.FromResult(new AsyncLockReleaser(this, AsyncLockType.Read, true));
+        _writerReleaserTask = Task.FromResult(new AsyncLockReleaser(this, AsyncLockType.Write, true));
     }
 
     internal AsyncLock(object syncObject)
+        : this()
     {
         _syncObj = syncObject;
     }
@@ -24,6 +28,10 @@ internal AsyncLock(object syncObject)
     private readonly Queue<TaskCompletionSource<AsyncLockReleaser>> _waitingReaders = new Queue<TaskCompletionSource<AsyncLockReleaser>>();
     private readonly Queue<TaskCompletionSource<AsyncLockReleaser>> _waitingWriters = new Queue<TaskCompletionSource<AsyncLockReleaser>>();
 
+    private readonly Task<AsyncLockReleaser> _readerReleaserTask;
+    private readonly Task<AsyncLockReleaser> _writerReleaserTask;
+    
+
     private int _readersRunning;
 
     private bool _isWriterRunning = false;
@@ -85,7 +93,7 @@ public Task<AsyncLockReleaser> ReaderLockAsync(CancellationToken cancellation =
             if (_isWriterRunning == false && _waitingWriters.Count == 0)
             {
                 _readersRunning++;
-                return Task.FromResult(new AsyncLockReleaser(this, AsyncLockType.Read, true));
+                return _readerReleaserTask;
             }
             else
             {
@@ -108,7 +116,7 @@ public Task<AsyncLockReleaser> WriterLockAsync(CancellationToken cancellation =
             if (_isWriterRunning == false && _readersRunning == 0)
             {
                 _isWriterRunning = true;
-                return Task.FromResult(new AsyncLockReleaser(this, AsyncLockType.Write, true));
+                return _writerReleaserTask;
             }
             else
             {
@@ -119,7 +127,7 @@ public Task<AsyncLockReleaser> WriterLockAsync(CancellationToken cancellation =
         }
     }
 
-    internal void Release(AsyncLockReleaser releaser, bool sendReleasedEvent = true)
+    internal void Release(AsyncLockReleaser releaser)
     {
         lock (_syncObj)
         {
@@ -136,7 +144,7 @@ internal void Release(AsyncLockReleaser releaser, bool sendReleasedEvent = true)
             }
             finally
             {
-                if (sendReleasedEvent)
+                if (State == AsyncLockState.Idle)
                 {
                     Released?.Invoke(this);
                 }

src/AsyncKeyLock/AsyncLockReleaser.cs

@@ -7,24 +7,22 @@ namespace AsyncKeyLock;
 /// <summary>
 /// AsyncLockReleaser
 /// </summary>
-public sealed class AsyncLockReleaser : IDisposable
+public readonly struct AsyncLockReleaser : IDisposable
 {
-    private bool _disposed;
-
     /// <summary>
     /// AsyncLock
     /// </summary>
-    private AsyncLock AsyncLock { get; }
+    private readonly AsyncLock AsyncLock;
 
     /// <summary>
     /// Type
     /// </summary>
-    public AsyncLockType Type { get; }
+    public readonly AsyncLockType Type;
 
     /// <summary>
     /// IsAcquiredImmediately
     /// </summary>
-    public bool IsAcquiredImmediately { get; }
+    public readonly bool IsAcquiredImmediately;
 
     internal AsyncLockReleaser(AsyncLock asyncLock, AsyncLockType type, bool lockAcquiredImmediately)
     {
@@ -35,15 +33,6 @@ internal AsyncLockReleaser(AsyncLock asyncLock, AsyncLockType type, bool lockAcq
 
     public void Dispose()
     {
-        if (_disposed)
-        {
-            return;
-        }
-
         AsyncLock.Release(this);
-        
-        _disposed = true;
-
-        GC.SuppressFinalize(this);
     }
-}
+}

src/AsyncKeyLock/AsyncLock~.cs

@@ -34,14 +34,10 @@ private AsyncLock GetAsyncLock(TKey key)
                     AsyncLock a = new AsyncLock(_locks);
                     a.Released += x =>
                     {
-                        //is AsyncLock idle
-                        if (x.State == AsyncLockState.Idle)
-                        {
-                            _locks.Remove(key);
+                        _locks.Remove(key);
 
-                            //add idle AsynLock to pool
-                            _pool.Add(x);
-                        }
+                        //add idle AsynLock to pool
+                        _pool.Add(x);
                     };
 
                     return a;