Skip to content

Commit 442e489

Browse files
committed
Replace jackiedo/dotenv-editor with our own implementation to avoid dependency on an unmaintained package.
1 parent 84c2d98 commit 442e489

File tree

11 files changed

+1776
-742
lines changed

11 files changed

+1776
-742
lines changed

.github/copilot-instructions.md

Lines changed: 30 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,13 +116,21 @@ npm run build:theme # @userfrosting/theme-pink-cupcake
116116

117117
**PHP tests** (PHPUnit):
118118
```bash
119+
# Run all tests
120+
vendor/bin/phpunit
121+
119122
# Run specific suite
120123
vendor/bin/phpunit --testsuite="Core Sprinkle"
121124
vendor/bin/phpunit --testsuite="Framework"
122125

123126
# Or use VS Code task "PHPUnit"
124127
```
125128

129+
Running all tests can be time consuming. During development, run tests for specific files or suites as needed first, then run the full suite before committing.
130+
```bash
131+
vendor/bin/phpunit tests/src/SomeClassTest.php
132+
```
133+
126134
**Frontend tests** (Vitest):
127135
```bash
128136
npm run test # Watch mode
@@ -131,7 +139,11 @@ npm run coverage # With coverage report
131139

132140
- Root [vitest.config.ts](vitest.config.ts) runs tests from all workspace packages
133141
- Uses `happy-dom` environment
134-
- Coverage: `_meta/_coverage/`
142+
- Coverage:
143+
- PHP : `_meta/coverage/`
144+
- JS : `_meta/_coverage/`
145+
146+
All changes should be covered by tests. New features require new tests. 100% code coverage is the goal.
135147

136148
### Database Setup
137149

@@ -191,6 +203,22 @@ const router = createRouter({
191203
})
192204
```
193205

206+
## Linting and Code Style
207+
Before any commit, make sure to run the linters. These **must** be run before committing code from the root of the monorepo.
208+
209+
```bash
210+
# PHP code style
211+
vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.php
212+
213+
# PHPStan static analysis
214+
vendor/bin/phpstan analyse -c phpstan.neon
215+
216+
# TypeScript code style
217+
npm run lint
218+
npm run format
219+
npm run typecheck
220+
```
221+
194222
## Release Process
195223

196224
**Before Releasing**:
@@ -235,5 +263,5 @@ npm publish --access public --workspaces
235263

236264
## Resources
237265

238-
- [Official Docs](https://learn.userfrosting.com)
266+
- [Official Docs](https://learn6.userfrosting.com)
239267
- [Chat](https://chat.userfrosting.com)

composer.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
"illuminate/redis": "^10.0",
3838
"illuminate/session": "^10.0",
3939
"illuminate/support": "^10.0",
40-
"jackiedo/dotenv-editor": "^2.1",
4140
"lcharette/webpack-encore-twig": "^1.1",
4241
"league/commonmark": "^2.7",
4342
"league/csv": "^9.2.1",

0 commit comments

Comments
 (0)