Don't swallow errors caused by errors in the model class when detecting models

Author: benedikt

CHANEGLOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased (main)
 
+- Don't swallow errors caused by errors in the model class when detecting models
+
 ## v1.0.0 (2025-04-08)
 
 - Fix detection of relationships when there are multiple associations between users and companies

lib/userlist/rails.rb

@@ -41,13 +41,9 @@ def self.current_company
 
     def self.detect_model(*names)
       names.each do |name|
-        begin
-          model = name.constantize
+        model = Object.const_get(name) if Object.const_defined?(name)
 
-          return model if model.is_a?(Class)
-        rescue NameError
-          false
-        end
+        return model if model.is_a?(Class)
       end
 
       nil

spec/userlist/rails_spec.rb

@@ -124,4 +124,22 @@
       end
     end
   end
+
+  describe '.detect_model' do
+    it 'should raise an error when the model name is invalid' do
+      expect { described_class.detect_model('invalid') }.to raise_error(NameError)
+    end
+
+    it 'should not raise an error when the model is not found' do
+      expect { described_class.detect_model('NonExistentModel') }.not_to raise_error
+    end
+
+    it 'should return the model class when it exists' do
+      expect(described_class.detect_model('User')).to eq(User)
+    end
+
+    it 'should return the first model that exists when given a list of model names' do
+      expect(described_class.detect_model('NonExistentModel', 'User')).to eq(User)
+    end
+  end
 end