fix chaotic: format golden_test/output before comparing

Now we run clang-format on both sides of diff
Its prevents problems due to clang-format version changes

Fixes: <#1024>

---

Pull Request resolved: <#1025>

Co-authored-by: segoon <[email protected]>
Co-authored-by: segoon <[email protected]>
Co-authored-by: segoon <[email protected]>
Co-authored-by: segoon <[email protected]>
Co-authored-by: segoon <[email protected]>
commit_hash:9d5ed72125bcb43a182439d6e5d0295a32436438

Author: 2 people

.mapping.json

@@ -231,6 +231,7 @@
   "chaotic/golden_tests/schemas/oneof/oneof.yaml":"taxi/uservices/userver/chaotic/golden_tests/schemas/oneof/oneof.yaml",
   "chaotic/golden_tests/schemas/oneofdiscriminator/oneofdiscriminator.yaml":"taxi/uservices/userver/chaotic/golden_tests/schemas/oneofdiscriminator/oneofdiscriminator.yaml",
   "chaotic/golden_tests/schemas/string/string.yaml":"taxi/uservices/userver/chaotic/golden_tests/schemas/string/string.yaml",
+  "chaotic/golden_tests/scripts/diff-clang-format.py":"taxi/uservices/userver/chaotic/golden_tests/scripts/diff-clang-format.py",
   "chaotic/include/userver/chaotic/array.hpp":"taxi/uservices/userver/chaotic/include/userver/chaotic/array.hpp",
   "chaotic/include/userver/chaotic/convert.hpp":"taxi/uservices/userver/chaotic/include/userver/chaotic/convert.hpp",
   "chaotic/include/userver/chaotic/convert/to.hpp":"taxi/uservices/userver/chaotic/include/userver/chaotic/convert/to.hpp",

chaotic/golden_tests/CMakeLists.txt

@@ -19,9 +19,14 @@ userver_target_generate_chaotic(
     RELATIVE_TO "${CMAKE_CURRENT_SOURCE_DIR}"
 )
 
-add_test(NAME chaotic-golden COMMAND # Diff returns 0 if files are the same, 1 if they differ
-                                     diff -uNrpB "${CMAKE_CURRENT_SOURCE_DIR}/output" "${CMAKE_CURRENT_BINARY_DIR}/src"
+add_test(
+    NAME chaotic-golden
+    COMMAND "${USERVER_CHAOTIC_PYTEST_PYTHON_BINARY}"
+    "${CMAKE_CURRENT_SOURCE_DIR}/scripts/diff-clang-format.py
+    --golden-dir "${CMAKE_CURRENT_SOURCE_DIR}/output"
+    --generated-dir "${CMAKE_CURRENT_BINARY_DIR}/src"
 )
+
 add_custom_target(
     update-golden-tests
     DEPENDS ${PROJECT_NAME}-chgen

chaotic/golden_tests/scripts/diff-clang-format.py

@@ -0,0 +1,70 @@
+import argparse
+import os
+import shutil
+import subprocess
+import sys
+import tempfile
+
+
+def is_binary_available(binary_name: str) -> bool:
+    try:
+        subprocess.checked_call(['which', binary_name], stdout=subprocess.DEVNULL)
+        return True
+    except subprocess.CalledProcessError:
+        return False
+
+
+def parse_args():
+    parser = argparse.ArgumentParser(description='Compare formatted source files.')
+    parser.add_argument(
+        '--golden-dir', required=True, help='Golden directory (e.g., ${CMAKE_CURRENT_SOURCE_DIR}/output)'
+    )
+    parser.add_argument(
+        '--generated-dir', required=True, help='Generated directory (e.g., ${CMAKE_CURRENT_BINARY_DIR}/src)'
+    )
+    return parser.parse_args()
+
+
+def walk_xpp(path: str) -> list[str]:
+    result = []
+
+    extensions = {'.hpp', '.cpp', '.ipp'}
+    for root, _, files in os.walk(path):
+        for file in files:
+            if file.lower().endswith(extensions):
+                file_path = os.path.join(root, file)
+                result.append(file_path)
+    return result
+
+
+def main():
+    args = parse_args()
+
+    if not is_binary_available('clang-format'):
+        print('Error: clang-format is not available in PATH', file=sys.stderr)
+        sys.exit(1)
+
+    if not is_binary_available('diff'):
+        print('Error: diff is not available in PATH', file=sys.stderr)
+        sys.exit(1)
+
+    with tempfile.TemporaryDirectory() as tmpdir:
+        golden_copy = os.path.join(tmpdir, 'golden')
+        generated_copy = os.path.join(tmpdir, 'generated')
+        shutil.copytree(args.golden_dir, golden_copy)
+        shutil.copytree(args.generated_dir, generated_copy)
+
+        subprocess.check_call(['clang-format', '-i'] + walk_xpp(tmpdir))
+
+        result = subprocess.run(['diff', '-uNrpB', golden_copy, generated_copy], capture_output=True, text=True)
+
+        if result.returncode != 0:
+            print(result.stdout)
+            print(result.stderr, file=sys.stderr)
+
+        # Diff returns 0 if files are the same, 1 if they differ
+        sys.exit(result.returncode)
+
+
+if __name__ == '__main__':
+    main()