feat universal: allow safe thread_local usage, add utilities for randomness

Author: Anton3

.mapping.json

@@ -3067,8 +3067,10 @@
   "universal/include/userver/cache/lru_set.hpp":"taxi/uservices/userver/universal/include/userver/cache/lru_set.hpp",
   "universal/include/userver/compiler/demangle.hpp":"taxi/uservices/userver/universal/include/userver/compiler/demangle.hpp",
   "universal/include/userver/compiler/impl/constexpr.hpp":"taxi/uservices/userver/universal/include/userver/compiler/impl/constexpr.hpp",
+  "universal/include/userver/compiler/impl/lifetime.hpp":"taxi/uservices/userver/universal/include/userver/compiler/impl/lifetime.hpp",
   "universal/include/userver/compiler/impl/tls.hpp":"taxi/uservices/userver/universal/include/userver/compiler/impl/tls.hpp",
   "universal/include/userver/compiler/select.hpp":"taxi/uservices/userver/universal/include/userver/compiler/select.hpp",
+  "universal/include/userver/compiler/thread_local.hpp":"taxi/uservices/userver/universal/include/userver/compiler/thread_local.hpp",
   "universal/include/userver/crypto/algorithm.hpp":"taxi/uservices/userver/universal/include/userver/crypto/algorithm.hpp",
   "universal/include/userver/crypto/base64.hpp":"taxi/uservices/userver/universal/include/userver/crypto/base64.hpp",
   "universal/include/userver/crypto/basic_types.hpp":"taxi/uservices/userver/universal/include/userver/crypto/basic_types.hpp",
@@ -3078,6 +3080,7 @@
   "universal/include/userver/crypto/hash.hpp":"taxi/uservices/userver/universal/include/userver/crypto/hash.hpp",
   "universal/include/userver/crypto/private_key.hpp":"taxi/uservices/userver/universal/include/userver/crypto/private_key.hpp",
   "universal/include/userver/crypto/public_key.hpp":"taxi/uservices/userver/universal/include/userver/crypto/public_key.hpp",
+  "universal/include/userver/crypto/random.hpp":"taxi/uservices/userver/universal/include/userver/crypto/random.hpp",
   "universal/include/userver/crypto/signers.hpp":"taxi/uservices/userver/universal/include/userver/crypto/signers.hpp",
   "universal/include/userver/crypto/verifiers.hpp":"taxi/uservices/userver/universal/include/userver/crypto/verifiers.hpp",
   "universal/include/userver/decimal64/decimal64.hpp":"taxi/uservices/userver/universal/include/userver/decimal64/decimal64.hpp",
@@ -3276,6 +3279,8 @@
   "universal/src/compiler/demangle_test.cpp":"taxi/uservices/userver/universal/src/compiler/demangle_test.cpp",
   "universal/src/compiler/relax_cpu.hpp":"taxi/uservices/userver/universal/src/compiler/relax_cpu.hpp",
   "universal/src/compiler/select_test.cpp":"taxi/uservices/userver/universal/src/compiler/select_test.cpp",
+  "universal/src/compiler/thread_local.cpp":"taxi/uservices/userver/universal/src/compiler/thread_local.cpp",
+  "universal/src/compiler/thread_local_test.cpp":"taxi/uservices/userver/universal/src/compiler/thread_local_test.cpp",
   "universal/src/crypto/algorithm.cpp":"taxi/uservices/userver/universal/src/crypto/algorithm.cpp",
   "universal/src/crypto/base.cpp":"taxi/uservices/userver/universal/src/crypto/base.cpp",
   "universal/src/crypto/base64.cpp":"taxi/uservices/userver/universal/src/crypto/base64.cpp",
@@ -3290,6 +3295,7 @@
   "universal/src/crypto/private_key.cpp":"taxi/uservices/userver/universal/src/crypto/private_key.cpp",
   "universal/src/crypto/public_key.cpp":"taxi/uservices/userver/universal/src/crypto/public_key.cpp",
   "universal/src/crypto/public_key_test.cpp":"taxi/uservices/userver/universal/src/crypto/public_key_test.cpp",
+  "universal/src/crypto/random.cpp":"taxi/uservices/userver/universal/src/crypto/random.cpp",
   "universal/src/crypto/signature_test.cpp":"taxi/uservices/userver/universal/src/crypto/signature_test.cpp",
   "universal/src/crypto/signers.cpp":"taxi/uservices/userver/universal/src/crypto/signers.cpp",
   "universal/src/crypto/verifiers.cpp":"taxi/uservices/userver/universal/src/crypto/verifiers.cpp",

core/include/userver/rcu/rcu.hpp

@@ -8,7 +8,7 @@
 #include <list>
 #include <unordered_set>
 
-#include <userver/compiler/impl/tls.hpp>
+#include <userver/compiler/thread_local.hpp>
 #include <userver/engine/async.hpp>
 #include <userver/engine/mutex.hpp>
 #include <userver/logging/log.hpp>
@@ -64,13 +64,8 @@ struct CachedData {
 };
 
 template <typename T, typename RcuTraits>
-USERVER_IMPL_PREVENT_TLS_CACHING CachedData<T, RcuTraits>& GetCachedData() {
-  thread_local CachedData<T, RcuTraits> cache;
-
-  // NOLINTNEXTLINE
-  USERVER_IMPL_PREVENT_TLS_CACHING_ASM;
-  return cache;
-}
+inline compiler::ThreadLocal local_cached_data =
+    [] { return CachedData<T, RcuTraits>{}; };
 
 uint64_t GetNextEpoch() noexcept;
 
@@ -415,8 +410,8 @@ class Variable final {
  private:
   T* GetCurrent() const { return current_.load(); }
 
-  impl::HazardPointerRecord<T, RcuTraits>* MakeHazardPointerCached() const {
-    auto& cache = impl::GetCachedData<T, RcuTraits>();
+  impl::HazardPointerRecord<T, RcuTraits>* MakeHazardPointerCached(
+      impl::CachedData<T, RcuTraits>& cache) const {
     auto* hp = cache.hp;
     T* ptr = nullptr;
     if (hp && cache.variable == this && cache.variable_epoch == epoch_) {
@@ -448,16 +443,16 @@ class Variable final {
   }
 
   impl::HazardPointerRecord<T, RcuTraits>& MakeHazardPointer() const {
-    auto* hp = MakeHazardPointerCached();
+    auto cache = impl::local_cached_data<T, RcuTraits>.Use();
+    auto* hp = MakeHazardPointerCached(*cache);
     if (!hp) {
       hp = MakeHazardPointerFast();
       // all buckets are full, create a new one
       if (!hp) hp = MakeHazardPointerSlow();
 
-      auto& cache = impl::GetCachedData<T, RcuTraits>();
-      cache.hp = hp;
-      cache.variable = this;
-      cache.variable_epoch = epoch_;
+      cache->hp = hp;
+      cache->variable = this;
+      cache->variable_epoch = epoch_;
     }
     UASSERT(&hp->owner == this);
     return *hp;

core/include/userver/storages/secdist/secdist.hpp

@@ -144,7 +144,7 @@ class Secdist final {
       EventSource::Function&& func);
 
   class Impl;
-  utils::FastPimpl<Impl, 1136, 16> impl_;
+  utils::FastPimpl<Impl, 1152, 16> impl_;
 };
 
 template <typename Class>

core/include/userver/utils/periodic_task.hpp

@@ -6,6 +6,7 @@
 #include <chrono>
 #include <functional>
 #include <optional>
+#include <random>
 #include <string>
 
 #include <userver/engine/condition_variable.hpp>
@@ -214,6 +215,7 @@ class PeriodicTask final {
   rcu::Variable<Settings> settings_;
   engine::SingleConsumerEvent changed_event_;
   std::atomic<bool> should_force_step_{false};
+  std::optional<std::minstd_rand> mutate_period_random_;
 
   // For kNow only
   engine::Mutex step_mutex_;

core/src/dump/common_test.cpp

@@ -51,14 +51,14 @@ TYPED_TEST(DumpCommonNumeric, Numeric) {
     EXPECT_TRUE(std::isnan(dump::FromBinary<Num>(
         dump::ToBinary<Num>(std::numeric_limits<Num>::quiet_NaN()))));
   } else {
-    auto& engine = utils::DefaultRandom();
     // 8-bit types are not allowed in uniform_int_distribution, so increase the
     // T size.
     std::uniform_int_distribution<std::common_type_t<Num, unsigned short>>
         distribution(std::numeric_limits<Num>::min(),
                      std::numeric_limits<Num>::max());
     for (int i = 0; i < 1000; ++i) {
-      TestWriteReadCycle(static_cast<Num>(distribution(engine)));
+      TestWriteReadCycle(
+          static_cast<Num>(utils::WithDefaultRandom(distribution)));
     }
   }
 }

core/src/dump/operations_encrypted.cpp

@@ -8,7 +8,7 @@
 #include <cryptopp/modes.h>
 #include <cryptopp/osrng.h>
 
-#include <userver/compiler/impl/tls.hpp>
+#include <userver/crypto/random.hpp>
 #include <userver/fs/blocking/write.hpp>
 #include <userver/utils/assert.hpp>
 #include <userver/utils/cpu_relax.hpp>
@@ -48,23 +48,12 @@ inline const unsigned char* GetBytes(const T& data) {
   return reinterpret_cast<const unsigned char*>(data.GetUnderlying().data());
 }
 
-USERVER_IMPL_PREVENT_TLS_CACHING IV GenerateIv() {
-  unsigned char iv[kIvSize];
-  thread_local ::CryptoPP::AutoSeededRandomPool pool;
-
-  // NOLINTNEXTLINE
-  USERVER_IMPL_PREVENT_TLS_CACHING_ASM;
-  pool.GenerateBlock(iv, kIvSize);
-
-  return IV(iv, iv + kIvSize);
-}
-
 EncryptedWriter::EncryptedWriter(std::string filename,
                                  const SecretKey& secret_key,
                                  boost::filesystem::perms perms,
                                  tracing::ScopeTime& scope)
     : impl_(std::move(filename), &scope) {
-  auto iv = GenerateIv();
+  IV iv{crypto::GenerateRandomBlock(kIvSize)};
   impl_->encryption.SetKeyWithIV(GetBytes(secret_key),
                                  secret_key.GetUnderlying().size(),
                                  GetBytes(iv), iv.size());
@@ -114,11 +103,11 @@ EncryptedReader::EncryptedReader(std::string filename,
                                  const SecretKey& secret_key) {
   impl_->filename = filename;
 
-  bool pump_all = false;
+  constexpr bool kPumpAll = false;
 
   IV iv;
   impl_->file = std::make_unique<::CryptoPP::FileSource>(
-      impl_->filename.c_str(), pump_all,
+      impl_->filename.c_str(), kPumpAll,
       new ::CryptoPP::StringSink(iv.GetUnderlying()));
 
   auto& file = *impl_->file;

core/src/engine/mutex_benchmark.cpp

@@ -180,7 +180,7 @@ void generic_contention_with_payload(benchmark::State& state) {
     while (run) {
       m->lock();
       for (int i = 0; i < 10; ++i) {
-        benchmark::DoNotOptimize(utils::DefaultRandom()());
+        benchmark::DoNotOptimize(utils::Rand());
       }
       m->unlock();
       ++local_lock_unlock_count;
@@ -194,7 +194,7 @@ void generic_contention_with_payload(benchmark::State& state) {
   for ([[maybe_unused]] auto _ : state) {
     m->lock();
     for (int i = 0; i < 10; ++i) {
-      benchmark::DoNotOptimize(utils::DefaultRandom()());
+      benchmark::DoNotOptimize(utils::Rand());
     }
     m->unlock();
     ++local_lock_unlock_count;

core/src/engine/task/task_context.cpp

@@ -8,6 +8,7 @@
 
 #include <engine/coro/pool.hpp>
 #include <logging/log_extra_stacktrace.hpp>
+#include <userver/compiler/impl/tls.hpp>
 #include <userver/engine/exception.hpp>
 #include <userver/engine/impl/task_context_factory.hpp>
 #include <userver/engine/task/cancel.hpp>
@@ -20,7 +21,6 @@
 #include <engine/task/coro_unwinder.hpp>
 #include <engine/task/cxxabi_eh_globals.hpp>
 #include <engine/task/task_processor.hpp>
-#include <userver/compiler/impl/tls.hpp>
 #include <utils/impl/assert_extra.hpp>
 
 USERVER_NAMESPACE_BEGIN
@@ -52,17 +52,14 @@ impl::TaskContext& GetCurrentTaskContext() noexcept {
         "outside of coroutine context");
   }
 
-  // NOLINTNEXTLINE
   USERVER_IMPL_PREVENT_TLS_CACHING_ASM;
 
   return *current_task_context_ptr;
 }
 
 USERVER_IMPL_PREVENT_TLS_CACHING
 impl::TaskContext* GetCurrentTaskContextUnchecked() noexcept {
-  // NOLINTNEXTLINE
   USERVER_IMPL_PREVENT_TLS_CACHING_ASM;
-
   return current_task_context_ptr;
 }
 

core/src/engine/task/task_counter.cpp

@@ -1,10 +1,8 @@
 #include <engine/task/task_counter.hpp>
 
-#include <algorithm>
 #include <thread>
 
-#include <userver/compiler/impl/constexpr.hpp>
-#include <userver/compiler/impl/tls.hpp>
+#include <userver/compiler/thread_local.hpp>
 #include <userver/utils/assert.hpp>
 
 USERVER_NAMESPACE_BEGIN
@@ -22,16 +20,9 @@ struct LocalTaskCounterData final {
   std::size_t task_processor_thread_index{};
 };
 
-thread_local USERVER_IMPL_CONSTINIT LocalTaskCounterData
-    local_task_counter_data;
-
-USERVER_IMPL_PREVENT_TLS_CACHING LocalTaskCounterData
-GetLocalTaskCounterData() noexcept {
-  // NOLINTNEXTLINE
-  USERVER_IMPL_PREVENT_TLS_CACHING_ASM;
-
-  return local_task_counter_data;
-}
+compiler::ThreadLocal local_task_counter_data = [] {
+  return LocalTaskCounterData{};
+};
 
 }  // namespace
 
@@ -176,26 +167,27 @@ Rate TaskCounter::GetApproximate(GlobalCounterId id) const noexcept {
 }
 
 void TaskCounter::Increment(LocalCounterId id) noexcept {
-  const auto local_data = GetLocalTaskCounterData();
-  UASSERT(local_data.local_counter == this);
-  auto& counter = (*local_counters_[local_data.task_processor_thread_index])
+  auto local_data = local_task_counter_data.Use();
+  UASSERT(local_data->local_counter == this);
+  auto& counter = (*local_counters_[local_data->task_processor_thread_index])
       [static_cast<std::size_t>(id)];
   counter.Store(counter.Load() + Rate{1});
 }
 
 void TaskCounter::Increment(GlobalCounterId id) noexcept {
-  const auto local_data = GetLocalTaskCounterData();
+  auto local_data = local_task_counter_data.Use();
   auto& counter =
-      (local_data.local_counter == this)
-          ? (*local_counters_[local_data.task_processor_thread_index])
+      (local_data->local_counter == this)
+          ? (*local_counters_[local_data->task_processor_thread_index])
                 [static_cast<std::size_t>(id)]
           : *global_counters_[static_cast<std::size_t>(id)];
   // seq_cst synchronizes-with MayHaveTasksAlive.
   counter.Add(Rate{1}, std::memory_order_seq_cst);
 }
 
 void SetLocalTaskCounterData(TaskCounter& counter, std::size_t thread_id) {
-  local_task_counter_data = {&counter, thread_id};
+  auto local_data = local_task_counter_data.Use();
+  *local_data = {&counter, thread_id};
 }
 
 }  // namespace engine::impl

core/src/engine/task/task_processor.cpp

@@ -56,7 +56,7 @@ void EmitMagicNanosleep() {
 
 void TaskProcessorThreadStartedHook() {
   utils::impl::AssertStaticRegistrationFinished();
-  (void)utils::DefaultRandom();
+  utils::WithDefaultRandom([](auto&) {});
   for (const auto& func : ThreadStartedHooks()) {
     func();
   }