feat universal: force USERVER_FILEPATH to return utils::zstring_view

Tests: протестировано CI
commit_hash:e9189656e5519909325fb753c15e51cff3c9ee87

Author: apolukhin

universal/include/userver/logging/log.hpp

@@ -231,7 +231,7 @@ struct EntryStorage final {
 #define USERVER_IMPL_DYNAMIC_DEBUG_ENTRY                                                                 \
     []() noexcept -> const USERVER_NAMESPACE::logging::impl::StaticLogEntry& {                           \
         struct NameHolder {                                                                              \
-            static constexpr const char* Get() noexcept { return USERVER_FILEPATH.data(); }              \
+            static constexpr const char* Get() noexcept { return USERVER_FILEPATH.c_str(); }             \
         };                                                                                               \
         const auto& entry = USERVER_NAMESPACE::logging::impl::EntryStorage<NameHolder, __LINE__>::entry; \
         return entry;                                                                                    \

universal/include/userver/logging/log_filepath.hpp

@@ -3,7 +3,9 @@
 /// @file userver/logging/log_filepath.hpp
 /// @brief Short source path calculator
 
-#include <string_view>
+#include <userver/compiler/impl/constexpr.hpp>
+#include <userver/utils/string_literal.hpp>
+#include <userver/utils/zstring_view.hpp>
 
 USERVER_NAMESPACE_BEGIN
 
@@ -12,12 +14,12 @@ USERVER_NAMESPACE_BEGIN
 
 /// @ingroup userver_universal
 ///
-/// @brief Short std::string_view with source path for logging.
+/// @brief Short @ref utils::zstring_view with source path for logging.
 /// @hideinitializer
 // We need user's filename here, not ours
 // NOLINTNEXTLINE(cppcoreguidelines-macro-usage)
 #define USERVER_FILEPATH \
-    std::string_view { __builtin_FILE() }
+    USERVER_NAMESPACE::utils::zstring_view { __builtin_FILE() }
 
 #else
 
@@ -30,8 +32,8 @@ namespace logging::impl {
 #define USERVER_LOG_FILEPATH_STRINGIZE(X) USERVER_LOG_FILEPATH_STRINGIZE_AUX(X)
 
 // May have different macro values for different translation units, hence static
-static constexpr std::size_t PathBaseSize(std::string_view path) noexcept {
-    constexpr std::string_view kSourcePathPrefixes[] = {
+static constexpr std::size_t PathBaseSize(utils::zstring_view path) noexcept {
+    constexpr utils::StringLiteral kSourcePathPrefixes[] = {
 #ifdef USERVER_LOG_PREFIX_PATH_BASE
         USERVER_LOG_FILEPATH_STRINGIZE(USERVER_LOG_PREFIX_PATH_BASE),
 #endif
@@ -43,7 +45,7 @@ static constexpr std::size_t PathBaseSize(std::string_view path) noexcept {
 #endif
     };
 
-    for (const std::string_view base : kSourcePathPrefixes) {
+    for (const utils::StringLiteral base : kSourcePathPrefixes) {
         if (path.substr(0, base.size()) == base) {
             std::size_t base_size = path.find_first_not_of('/', base.size());
             if (base_size == std::string_view::npos) {
@@ -56,10 +58,11 @@ static constexpr std::size_t PathBaseSize(std::string_view path) noexcept {
     return 0;
 }
 
-// TODO: consteval
-static constexpr std::string_view CutFilePath(const char* path) noexcept {
-    const std::string_view path_view = path;
-    return path_view.substr(impl::PathBaseSize(path_view));
+// May have different macro values for different translation units, hence static. `consteval` breaks the behavior of
+// utils::SourceLocation.
+static constexpr utils::zstring_view CutFilePath(utils::zstring_view path_view) noexcept {
+    path_view.remove_prefix(impl::PathBaseSize(path_view));
+    return path_view;
 }
 
 #undef USERVER_LOG_FILEPATH_STRINGIZE

universal/include/userver/utils/string_literal.hpp

@@ -12,7 +12,6 @@
 
 #include <userver/compiler/impl/constexpr.hpp>
 #include <userver/formats/serialize/to.hpp>
-#include <userver/utils/assert.hpp>
 #include <userver/utils/zstring_view.hpp>
 
 USERVER_NAMESPACE_BEGIN

universal/include/userver/utils/zstring_view.hpp

@@ -11,12 +11,14 @@
 #include <fmt/format.h>
 
 #include <userver/formats/serialize/to.hpp>
-#include <userver/utils/assert.hpp>
 
 USERVER_NAMESPACE_BEGIN
 
 namespace utils {
 
+// Forward declaration
+[[noreturn]] void AbortWithStacktrace(std::string_view message) noexcept;
+
 /// @ingroup userver_containers
 ///
 /// @brief Non-empty string view type that guarantees null-termination and has a `c_str()` member function.
@@ -48,8 +50,11 @@ class zstring_view : public std::string_view {  // NOLINT(readability-identifier
 
 private:
     constexpr zstring_view(const char* str, std::size_t len) noexcept : std::string_view{str, len} {
-        UASSERT_MSG(str, "null not allowed");
-        UASSERT_MSG(str[len] == 0, "Not null-terminated");
+#ifndef NDEBUG
+        if (!str || str[len] != 0) {
+            USERVER_NAMESPACE::utils::AbortWithStacktrace("`str` should be not null and should be null terminated");
+        }
+#endif
     }
 };