feat userver: use std::move()

commit_hash:1cd312b6c28f410c06235c462564cdeb15d2030e

Author: segoon

clickhouse/include/userver/storages/clickhouse/io/columns/array_column.hpp

@@ -96,7 +96,7 @@ bool ArrayColumn<T>::ArrayDataHolder::operator==(const ArrayDataHolder& other) c
 }
 
 template <typename T>
-ArrayColumn<T>::ArrayColumn(ColumnRef column) : ClickhouseColumn<ArrayColumn>{column} {}
+ArrayColumn<T>::ArrayColumn(ColumnRef column) : ClickhouseColumn<ArrayColumn>{std::move(column)} {}
 
 template <typename T>
 ColumnRef ArrayColumn<T>::Serialize(const container_type& from) {

clickhouse/include/userver/storages/clickhouse/io/columns/nullable_column.hpp

@@ -67,7 +67,7 @@ class NullableColumn final : public ClickhouseColumn<NullableColumn<T>> {
 };
 
 template <typename T>
-NullableColumn<T>::NullableColumn(ColumnRef column) : ClickhouseColumn<NullableColumn>{column} {}
+NullableColumn<T>::NullableColumn(ColumnRef column) : ClickhouseColumn<NullableColumn>{std::move(column)} {}
 
 template <typename T>
 NullableColumn<T>::NullableDataHolder::NullableDataHolder(

clickhouse/src/storages/clickhouse/impl/block_wrapper.cpp

@@ -4,7 +4,7 @@ USERVER_NAMESPACE_BEGIN
 
 namespace storages::clickhouse::impl {
 
-BlockWrapper::BlockWrapper(clickhouse_cpp::Block&& block) : native_{block} {}
+BlockWrapper::BlockWrapper(clickhouse_cpp::Block&& block) : native_{std::move(block)} {}
 
 clickhouse_cpp::ColumnRef BlockWrapper::At(size_t ind) const { return native_[ind]; }
 

core/include/userver/dump/operations.hpp

@@ -16,7 +16,7 @@ namespace dump {
 /// should be performed with a failed dump.
 class Error final : public std::runtime_error {
 public:
-    explicit Error(std::string message) : std::runtime_error(message) {}
+    explicit Error(std::string message) : std::runtime_error(std::move(message)) {}
 };
 
 /// A general interface for binary data output

core/src/baggage/baggage.cpp

@@ -304,7 +304,7 @@ std::optional<BaggageEntry> Baggage::TryMakeBaggageEntry(std::string_view entry)
             }
         }
     }
-    return std::make_optional<BaggageEntry>({key, value, properties});
+    return std::make_optional<BaggageEntry>({key, value, std::move(properties)});
 }
 
 std::optional<BaggageEntryProperty> Baggage::TryMakeBaggageEntryProperty(std::string_view property) {

core/src/concurrent/conflated_event_channel.cpp

@@ -8,7 +8,7 @@ USERVER_NAMESPACE_BEGIN
 namespace concurrent {
 
 ConflatedEventChannel::ConflatedEventChannel(std::string name, OnRemoveCallback on_listener_removal)
-    : AsyncEventChannel<>(std::move(name), on_listener_removal), stop_flag_(false) {
+    : AsyncEventChannel<>(std::move(name), std::move(on_listener_removal)), stop_flag_(false) {
     LOG_DEBUG() << Name() << ": start event listener task";
     task_ = utils::Async(Name() + "/event_listener", [this] {
         while (event_.WaitForEvent()) {

core/src/congestion_control/controllers/linear.cpp

@@ -27,7 +27,7 @@ LinearController::LinearController(
       long_timings_(kLongTimingsEpochs),
       short_timings_(kShortTimingsEpochs),
       config_source_(config_source),
-      config_getter_(config_getter) {}
+      config_getter_(std::move(config_getter)) {}
 
 Limit LinearController::Update(const Sensor::Data& current) {
     auto dyn_config = config_source_.GetSnapshot();

core/src/dump/dump_locator.cpp

@@ -23,7 +23,7 @@ const std::string kTimeZone = "UTC";
 }  // namespace
 
 DumpLocator::DumpLocator(Config static_config)
-    : config_(static_config),
+    : config_(std::move(static_config)),
       filename_regex_(GenerateFilenameRegex(FileFormatType::kNormal)),
       tmp_filename_regex_(GenerateFilenameRegex(FileFormatType::kTmp)) {}
 

core/src/fs/temp_file.cpp

@@ -30,7 +30,7 @@ TempFile::Create(std::string_view parent_path, std::string_view name_prefix, eng
 TempFile::~TempFile() { std::move(*this).Remove(); }
 
 TempFile TempFile::Adopt(std::string path, engine::TaskProcessor& fs_task_processor) {
-    return {fs_task_processor, blocking::TempFile::Adopt(path)};
+    return {fs_task_processor, blocking::TempFile::Adopt(std::move(path))};
 }
 
 const std::string& TempFile::GetPath() const { return temp_file_.GetPath(); }

core/src/logging/tp_logger_utils.cpp

@@ -32,7 +32,7 @@ void CreateLogDirectory(const std::string& logger_name, const std::string& file_
     } catch (const std::exception& e) {
         auto msg = "Failed to create directory for log file of logger '" + logger_name + "': " + e.what();
         LOG_ERROR() << msg;
-        throw std::runtime_error(msg);
+        throw std::runtime_error(std::move(msg));
     }
 }