feat postgresql: more robust dtr

segoon · segoon · commit 53152148b172 · 2025-12-04T12:00:22.000+03:00
commit_hash:431858001600f9683c617316311ad08d30b722e2
diff --git a/postgresql/src/storages/postgres/detail/pool.cpp b/postgresql/src/storages/postgres/detail/pool.cpp
@@ -590,7 +590,14 @@ void ConnectionPool::Clear() {
     while (conn_consumer_.PopNoblock(connection)) {
         delete connection;
     }
+
+    // A close task may still call Push(),
+    // so cleanup queue after the task storage
     close_task_storage_.CancelAndWait();
+
+    queue_.reset();
+    std::move(conn_consumer_).Reset();
+    std::move(conn_producer_).Reset();
 }
 
 void ConnectionPool::CleanupConnection(Connection* connection) {

Original file line number	Diff line number	Diff line change
`@@ -590,7 +590,14 @@ void ConnectionPool::Clear() {`
`590`	`590`	`while (conn_consumer_.PopNoblock(connection)) {`
`591`	`591`	`delete connection;`
`592`	`592`	`}`
	`593`	`+`
	`594`	`+ // A close task may still call Push(),`
	`595`	`+ // so cleanup queue after the task storage`
`593`	`596`	`close_task_storage_.CancelAndWait();`
	`597`	`+`
	`598`	`+ queue_.reset();`
	`599`	`+ std::move(conn_consumer_).Reset();`
	`600`	`+ std::move(conn_producer_).Reset();`
`594`	`601`	`}`
`595`	`602`
`596`	`603`	`void ConnectionPool::CleanupConnection(Connection* connection) {`