fix build: rm fmt::localtime usage in grpc

Use `::localtime_r` instead for now.
commit_hash:1f106dbc6d9256c8215b463733c03a4f118285ae

Author: Anton3

.mapping.json

@@ -5058,6 +5058,7 @@
   "universal/include/userver/logging/impl/logger_base.hpp":"taxi/uservices/userver/universal/include/userver/logging/impl/logger_base.hpp",
   "universal/include/userver/logging/impl/mem_logger.hpp":"taxi/uservices/userver/universal/include/userver/logging/impl/mem_logger.hpp",
   "universal/include/userver/logging/impl/tag_writer.hpp":"taxi/uservices/userver/universal/include/userver/logging/impl/tag_writer.hpp",
+  "universal/include/userver/logging/impl/timestamp.hpp":"taxi/uservices/userver/universal/include/userver/logging/impl/timestamp.hpp",
   "universal/include/userver/logging/json_string.hpp":"taxi/uservices/userver/universal/include/userver/logging/json_string.hpp",
   "universal/include/userver/logging/level.hpp":"taxi/uservices/userver/universal/include/userver/logging/level.hpp",
   "universal/include/userver/logging/log.hpp":"taxi/uservices/userver/universal/include/userver/logging/log.hpp",
@@ -5347,6 +5348,7 @@
   "universal/src/logging/impl/logger_base.cpp":"taxi/uservices/userver/universal/src/logging/impl/logger_base.cpp",
   "universal/src/logging/impl/mem_logger.cpp":"taxi/uservices/userver/universal/src/logging/impl/mem_logger.cpp",
   "universal/src/logging/impl/tag_writer.cpp":"taxi/uservices/userver/universal/src/logging/impl/tag_writer.cpp",
+  "universal/src/logging/impl/timestamp.cpp":"taxi/uservices/userver/universal/src/logging/impl/timestamp.cpp",
   "universal/src/logging/json_string.cpp":"taxi/uservices/userver/universal/src/logging/json_string.cpp",
   "universal/src/logging/level.cpp":"taxi/uservices/userver/universal/src/logging/level.cpp",
   "universal/src/logging/log.cpp":"taxi/uservices/userver/universal/src/logging/log.cpp",
@@ -5362,8 +5364,6 @@
   "universal/src/logging/rate_limit.cpp":"taxi/uservices/userver/universal/src/logging/rate_limit.cpp",
   "universal/src/logging/rate_limit.hpp":"taxi/uservices/userver/universal/src/logging/rate_limit.hpp",
   "universal/src/logging/stacktrace_cache.cpp":"taxi/uservices/userver/universal/src/logging/stacktrace_cache.cpp",
-  "universal/src/logging/timestamp.cpp":"taxi/uservices/userver/universal/src/logging/timestamp.cpp",
-  "universal/src/logging/timestamp.hpp":"taxi/uservices/userver/universal/src/logging/timestamp.hpp",
   "universal/src/tracing/opentelemetry.cpp":"taxi/uservices/userver/universal/src/tracing/opentelemetry.cpp",
   "universal/src/tracing/opentelemetry_benchmark.cpp":"taxi/uservices/userver/universal/src/tracing/opentelemetry_benchmark.cpp",
   "universal/src/tracing/opentelemetry_test.cpp":"taxi/uservices/userver/universal/src/tracing/opentelemetry_test.cpp",

grpc/src/ugrpc/server/impl/format_log_message.cpp

@@ -4,12 +4,11 @@
 #include <fmt/compile.h>
 #include <fmt/format.h>
 
-#include <userver/compiler/thread_local.hpp>
 #include <userver/logging/impl/logger_base.hpp>
+#include <userver/logging/impl/timestamp.hpp>
 #include <userver/ugrpc/impl/to_string.hpp>
 #include <userver/utils/datetime.hpp>
 #include <userver/utils/encoding/tskv.hpp>
-#include <userver/utils/impl/source_location.hpp>
 #include <userver/utils/text_light.hpp>
 
 USERVER_NAMESPACE_BEGIN
@@ -41,39 +40,6 @@ std::string ParseIp(std::string_view sv) {
     return EscapeForAccessTskvLog(sv);
 }
 
-using SecondsTimePoint = std::chrono::time_point<std::chrono::system_clock, std::chrono::seconds>;
-
-constexpr std::string_view kTimeTemplate = "0000-00-00T00:00:00";
-
-struct CachedTime final {
-    SecondsTimePoint cached_time{};
-    char cached_time_string[kTimeTemplate.size()]{};
-};
-
-compiler::ThreadLocal local_time_cache = [] { return CachedTime{}; };
-
-std::string_view GetCurrentTimeString(std::chrono::system_clock::time_point start_time) noexcept {
-    auto cache = local_time_cache.Use();
-    const auto rounded_now = std::chrono::time_point_cast<std::chrono::seconds>(start_time);
-    if (rounded_now != cache->cached_time) {
-        fmt::format_to(
-            cache->cached_time_string,
-            FMT_COMPILE("{:%FT%T}"),
-            fmt::localtime(std::chrono::system_clock::to_time_t(start_time))
-        );
-        cache->cached_time = rounded_now;
-    }
-
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wreturn-stack-address"
-#endif
-    return std::string_view{cache->cached_time_string, kTimeTemplate.size()};
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
-}
-
 }  // namespace
 
 logging::impl::LogExtraTskvFormatter FormatLogMessage(
@@ -113,7 +79,7 @@ logging::impl::LogExtraTskvFormatter FormatLogMessage(
         "\tupstream_response_time={}.{:0>3}"
         "\tgrpc_status={}"
         "\tgrpc_status_code={}",
-        GetCurrentTimeString(start_time),
+        logging::impl::GetCurrentLocalTimeString(start_time).ToStringView(),
         kTimezone,
         EscapeForAccessTskvLog(user_agent),
         ip,

universal/include/userver/logging/impl/timestamp.hpp

@@ -0,0 +1,24 @@
+#pragma once
+
+#include <chrono>
+#include <string_view>
+
+USERVER_NAMESPACE_BEGIN
+
+namespace logging::impl {
+
+inline constexpr std::string_view kTimeTemplate = "0000-00-00T00:00:00";
+
+struct TimeString final {
+    char data[kTimeTemplate.size()]{};
+
+    std::string_view ToStringView() const noexcept { return {data, std::size(data)}; }
+};
+
+TimeString GetCurrentGMTimeString(std::chrono::system_clock::time_point now) noexcept;
+TimeString GetCurrentLocalTimeString(std::chrono::system_clock::time_point now) noexcept;
+std::chrono::microseconds::rep FractionalMicroseconds(std::chrono::system_clock::time_point time) noexcept;
+
+}  // namespace logging::impl
+
+USERVER_NAMESPACE_END

universal/src/logging/impl/formatters/json.cpp

@@ -5,7 +5,7 @@
 #include <fmt/compile.h>
 #include <fmt/format.h>
 
-#include <logging/timestamp.hpp>
+#include <userver/logging/impl/timestamp.hpp>
 
 USERVER_NAMESPACE_BEGIN
 

universal/src/logging/impl/formatters/struct.cpp

@@ -5,7 +5,7 @@
 #include <fmt/compile.h>
 #include <fmt/format.h>
 
-#include <logging/timestamp.hpp>
+#include <userver/logging/impl/timestamp.hpp>
 
 USERVER_NAMESPACE_BEGIN
 

universal/src/logging/impl/formatters/tskv.cpp

@@ -4,9 +4,8 @@
 #include <fmt/compile.h>
 #include <fmt/format.h>
 
-#include <logging/timestamp.hpp>
-
 #include <userver/compiler/thread_local.hpp>
+#include <userver/logging/impl/timestamp.hpp>
 #include <userver/utils/assert.hpp>
 #include <userver/utils/encoding/tskv.hpp>
 
@@ -49,7 +48,7 @@ Tskv::Tskv(Level level, Format format, const utils::impl::SourceLocation& locati
         }
         case Format::kLtsv: {
             constexpr std::string_view kTemplate = "timestamp:0000-00-00T00:00:00.000000\tlevel:\tmodule: ( : )";
-            const auto now = TimePoint::clock::now();
+            const auto now = std::chrono::system_clock::now();
             const auto level_string = logging::ToUpperCaseString(level);
             item_.log_line.resize_and_overwrite(
                 kTemplate.size() + level_string.size() + location.GetFunctionName().size() +

universal/src/logging/timestamp.cpp universal/src/logging/impl/timestamp.cppuniversal/src/logging/timestamp.cpp renamed to universal/src/logging/impl/timestamp.cpp

@@ -1,18 +1,20 @@
-#include <logging/timestamp.hpp>
+#include <userver/logging/impl/timestamp.hpp>
 
 #include <fmt/chrono.h>
 #include <fmt/compile.h>
 #include <fmt/format.h>
 
+#include <userver/compiler/thread_local.hpp>
 #include <userver/utils/assert.hpp>
 #include <userver/utils/strerror.hpp>
 
 USERVER_NAMESPACE_BEGIN
 
-namespace logging {
+namespace logging::impl {
 
 namespace {
 
+using TimePoint = std::chrono::system_clock::time_point;
 using SecondsTimePoint = std::chrono::time_point<TimePoint::clock, std::chrono::seconds>;
 
 struct CachedTime final {
@@ -42,20 +44,20 @@ compiler::ThreadLocal thread_local_cached_gmt_time = [] { return CachedTime{}; }
 compiler::ThreadLocal thread_local_cached_local_time = [] { return CachedTime{}; };
 }  // namespace
 
-unsigned long FractionalMicroseconds(TimePoint time) noexcept {
+std::chrono::microseconds::rep FractionalMicroseconds(std::chrono::system_clock::time_point time) noexcept {
     return std::chrono::time_point_cast<std::chrono::microseconds>(time).time_since_epoch().count() % 1'000'000;
 }
 
-TimeString GetCurrentGMTimeString(TimePoint now) noexcept {
+TimeString GetCurrentGMTimeString(std::chrono::system_clock::time_point now) noexcept {
     auto cached_time = thread_local_cached_gmt_time.Use();
     return GetCurrentTimeString<gmtime_r>(now, cached_time);
 }
 
-TimeString GetCurrentLocalTimeString(TimePoint now) noexcept {
+TimeString GetCurrentLocalTimeString(std::chrono::system_clock::time_point now) noexcept {
     auto cached_time = thread_local_cached_local_time.Use();
     return GetCurrentTimeString<localtime_r>(now, cached_time);
 }
 
-}  // namespace logging
+}  // namespace logging::impl
 
 USERVER_NAMESPACE_END