feat s3api: include body in the s3 exception

Tests: CI
commit_hash:d6c1a7e597bf1bed73154c5d4c7644c107ff14bf

Author: TTPO100AJIEX

core/include/userver/clients/http/response.hpp

@@ -51,11 +51,19 @@ class Response final {
     bool IsError() const { return static_cast<uint16_t>(status_code()) >= 400; }
 
     static void RaiseForStatus(int code, const LocalStats& stats);
+    static void RaiseForStatus(int code, const LocalStats& stats, std::string_view message);
 
-    void raise_for_status() const;
+    /// @brief Configuration whether to include the response body in the exception in @ref raise_for_status.
+    enum class RaiseIncludeBody : std::uint8_t { kNo = 0, kYes = 1 };
 
-    /// returns statistics on request execution like count of opened sockets,
-    /// connect time...
+    /// @brief Raise an exception depending on the response status.
+    ///        The body of the response may be included in the exception depending on the @param include_body.
+    ///
+    /// @throws HttpClientException for statuses [400; 500)
+    /// @throws HttpServerException for statuses [500; 600)
+    void raise_for_status(RaiseIncludeBody include_body = RaiseIncludeBody::kNo) const;
+
+    /// returns statistics on request execution like count of opened sockets, connect time...
     LocalStats GetStats() const;
 
     void SetStats(const LocalStats& stats) { stats_ = stats; }

core/src/clients/http/response.cpp

@@ -1,6 +1,9 @@
 #include <userver/clients/http/response.hpp>
 
+#include <fmt/core.h>
+
 #include <userver/clients/http/response_future.hpp>
+#include <userver/utils/assert.hpp>
 
 USERVER_NAMESPACE_BEGIN
 
@@ -16,7 +19,25 @@ void Response::RaiseForStatus(int code, const LocalStats& stats) {
     }
 }
 
-void Response::raise_for_status() const { RaiseForStatus(status_code(), GetStats()); }
+void Response::RaiseForStatus(int code, const LocalStats& stats, std::string_view message) {
+    if (400 <= code && code < 500) {
+        throw HttpClientException(code, stats, message);
+    } else if (500 <= code && code < 600) {
+        throw HttpServerException(code, stats, message);
+    }
+}
+
+void Response::raise_for_status(RaiseIncludeBody include_body) const {
+    switch (include_body) {
+        case RaiseIncludeBody::kNo:
+            RaiseForStatus(status_code(), GetStats());
+            return;
+        case RaiseIncludeBody::kYes:
+            RaiseForStatus(status_code(), GetStats(), body());
+            return;
+    }
+    UINVARIANT(false, fmt::format("Unhandled 'include_body' value: {}", static_cast<int>(include_body)));
+}
 
 LocalStats Response::GetStats() const { return stats_; }
 

libraries/s3api/src/s3api/s3_connection.cpp

@@ -58,7 +58,7 @@ std::shared_ptr<clients::http::Response> S3Connection::RequestApi(Request& r, st
     std::shared_ptr<clients::http::Response> response;
     try {
         response = GetMethod(http_req, full_url, r.body, r.method).perform();
-        response->raise_for_status();
+        response->raise_for_status(clients::http::Response::RaiseIncludeBody::kYes);
     } catch (const clients::http::TimeoutException& e) {
         LOG_WARNING() << "S3Api : Http Request Timeout: " << full_url;
         throw;