feat server: open monitor port early

commit_hash:ead7322200fed5f6078e18c67fe99651b2f13b1d

Author: segoon

core/functional_tests/early_monitor_port_open/tests/test_boot.py

@@ -1,10 +1,8 @@
 import asyncio
 
 import aiohttp
-import pytest
 
 
-@pytest.mark.skip(reason='the feature is not yet enabled')
 async def test_monitor_port_is_open_before_all_components_are_ready(
     ensure_daemon_started,
     service_daemon_scope,

core/include/userver/server/server.hpp

@@ -53,6 +53,7 @@ class Server final : public congestion_control::Limitee, public congestion_contr
 
     const http::HttpRequestHandler& GetHttpRequestHandler(bool is_monitor = false) const;
 
+    void StartMonitorPort();
     void Start();
 
     void Stop();

core/src/server/component.cpp

@@ -44,6 +44,8 @@ Server::Server(
         statistics_storage.RegisterWriter("http.handler.total", [this](utils::statistics::Writer& writer) {
             return server_->WriteTotalHandlerStatistics(writer);
         });
+
+    server_->StartMonitorPort();
 }
 
 Server::~Server() {

core/src/server/server.cpp

@@ -112,7 +112,8 @@ class ServerImpl final {
     );
     ~ServerImpl();
 
-    void StartPortInfos();
+    void StartPortInfo();
+    void StartMonitorPortInfo();
     void Stop();
 
     void AddHandler(const handlers::HttpHandlerBase& handler, engine::TaskProcessor& task_processor);
@@ -178,7 +179,7 @@ ServerImpl::ServerImpl(
 
 ServerImpl::~ServerImpl() { Stop(); }
 
-void ServerImpl::StartPortInfos() {
+void ServerImpl::StartPortInfo() {
     UASSERT(main_port_info_.request_handler);
 
     if (has_requests_view_watchers_.load()) {
@@ -189,12 +190,14 @@ void ServerImpl::StartPortInfos() {
     }
 
     main_port_info_.Start();
+
     main_port_info_.request_handler->DisableAddHandler();
     if (monitor_port_info_.request_handler) {
         monitor_port_info_.request_handler->DisableAddHandler();
     }
+}
 
-    // TODO: move to ctr for early start
+void ServerImpl::StartMonitorPortInfo() {
     if (monitor_port_info_.request_handler) {
         monitor_port_info_.Start();
     } else {
@@ -383,10 +386,17 @@ const http::HttpRequestHandler& Server::GetHttpRequestHandler(bool is_monitor) c
     return pimpl_->GetHttpRequestHandler(is_monitor);
 }
 
+void Server::StartMonitorPort()
+{
+    LOG_INFO() << "Starting monitor port";
+    pimpl_->StartMonitorPortInfo();
+    LOG_INFO() << "Monitor port is started";
+}
+
 void Server::Start() {
-    LOG_INFO() << "Starting server";
-    pimpl_->StartPortInfos();
-    LOG_INFO() << "Server is started";
+    LOG_INFO() << "Starting server port";
+    pimpl_->StartPortInfo();
+    LOG_INFO() << "Server port is started";
 }
 
 void Server::Stop() { pimpl_->Stop(); }