Skip to content

Commit 72724aa

Browse files
pavelbezpravelapolukhin
authored andcommitted
fix build: add missing check for mongodb in conan
There was an error when I created userver package: ```bash conan create \ . \ --build=missing \ -pr:b=default \ -s build_type=Release \ -o userver:shared=False \ -o userver:fPIC=True \ -o userver:lto=True \ -o userver:with_jemalloc=True \ -o userver:with_mongodb=False \ -o userver:with_postgresql=False \ -o userver:with_postgresql_extra=False \ -o userver:with_redis=False \ -o userver:with_grpc=True \ -o userver:with_clickhouse=False \ -o userver:with_rabbitmq=False \ -o userver:with_utest=True ``` ``` ERROR: userver/1.0.0: Error in validate() method, line 148 if self.dependencies['mongo-c-driver'].options.with_sasl != 'cyrus': KeyError: {'ref': mongo-c-driver/unknown@unknown/unknown, 'build': False, 'direct': True, 'test': False, 'visible': True} ``` The package builds successfully with this patch: ``` userver/1.0.0: Package 'f3b5a9314d5c7fe7ae4a85e24462b1f400f83d8d' created userver/1.0.0: Created package revision db3d8d666ab7f36e737ac91b7746dccd ``` I guess it came from [!387](#387) I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/ Tests: протестировано CI Pull Request resolved: #439
1 parent ed8517c commit 72724aa

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

conanfile.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,11 @@ def requirements(self):
145145
)
146146

147147
def validate(self):
148-
if self.dependencies['mongo-c-driver'].options.with_sasl != 'cyrus':
148+
if (
149+
self.options.with_mongodb
150+
and self.dependencies['mongo-c-driver'].options.with_sasl
151+
!= 'cyrus'
152+
):
149153
raise errors.ConanInvalidConfiguration(
150154
f'{self.ref} requires mongo-c-driver with_sasl cyrus',
151155
)

0 commit comments

Comments
 (0)