feat redis: more robust redis cluster tests

1) use pytest\_userver.utils.sync.wait\*()

2) use async instead of blocking API where possible

3) reuse redis.asyncio.ConnectionPool for Redis client
commit_hash:9aa4b5767d4b60a2a23b4e314817625c385c6e15

Author: segoon

redis/functional_tests/cluster_auto_topology/tests/test_redis_cluster.py

@@ -1,13 +1,11 @@
 import asyncio
-import logging
-import time
+
+import pytest_userver.utils.sync as sync
 
 KEYS_SEQ_LEN = 20  # enough sequential keys to test all slots
 REDIS_PORT = 6379
 FAILOVER_DEADLINE_SEC = 30  # maximum time allowed to finish failover
 
-logger = logging.getLogger(__name__)
-
 
 async def test_happy_path(service_client, redis_cluster_topology):
     post_reqs = [
@@ -51,21 +49,17 @@ async def test_hard_failover(service_client, redis_cluster_topology):
 
     # Start the failover
     redis_cluster_topology.get_masters()[0].stop()
-    # wait until service detect that shard 0 is broken
-    time.sleep(6)
 
+    # wait until service detect that shard 0 is broken
     # Failover starts in ~10 seconds
-    for _ in range(FAILOVER_DEADLINE_SEC):
-        write_ok = await _check_write_all_slots(
+    async def is_ready():
+        return await _check_write_all_slots(
             service_client,
             'hf_key2',
             'cde',
         )
-        if not write_ok:
-            await asyncio.sleep(1)
-            continue
-        break
-    assert write_ok
+
+    await sync.wait(is_ready)
 
     # Now that one of the replicas has become the master,
     # check reading from the remaining replica
@@ -80,18 +74,14 @@ async def test_add_shard(service_client, redis_cluster_topology):
     await redis_cluster_topology.add_shard()
 
     # Failover starts in ~10 seconds
-    for _ in range(FAILOVER_DEADLINE_SEC):
-        write_ok = await _check_write_all_slots(
+    async def is_ready():
+        return await _check_write_all_slots(
             service_client,
             'hf_key2',
             'cde',
         )
-        if not write_ok:
-            await asyncio.sleep(1)
-            continue
 
-        break
-    assert write_ok
+    await sync.wait(is_ready)
 
     # Now that one of the replicas has become the master,
     # check reading from the remaining replica

redis/functional_tests/pytest_redis_cluster_topology_plugin/configs/cluster.conf

@@ -10,3 +10,5 @@ cluster-enabled yes
 
 save ""
 
+loglevel debug
+