cc core: add a test that OnAllComponentsAreStopping is called in the documented order

See @ref components::ServiceLifetimeStage for docs of the order in which callbacks are called.

This PR changes neither the order nor the docs.
commit_hash:75aeb6380f6aa1c2b0ca1d8fcbd85deb5ff1a27a

Author: Anton3

.mapping.json

@@ -1296,6 +1296,7 @@
   "core/src/components/component_context_impl.cpp":"taxi/uservices/userver/core/src/components/component_context_impl.cpp",
   "core/src/components/component_context_impl.hpp":"taxi/uservices/userver/core/src/components/component_context_impl.hpp",
   "core/src/components/component_fwd.cpp":"taxi/uservices/userver/core/src/components/component_fwd.cpp",
+  "core/src/components/component_lifecycle_test.cpp":"taxi/uservices/userver/core/src/components/component_lifecycle_test.cpp",
   "core/src/components/component_list.cpp":"taxi/uservices/userver/core/src/components/component_list.cpp",
   "core/src/components/component_list_test.cpp":"taxi/uservices/userver/core/src/components/component_list_test.cpp",
   "core/src/components/component_list_test.hpp":"taxi/uservices/userver/core/src/components/component_list_test.hpp",
@@ -1325,8 +1326,8 @@
   "core/src/components/minimal_server_component_list_test.cpp":"taxi/uservices/userver/core/src/components/minimal_server_component_list_test.cpp",
   "core/src/components/process_starter.cpp":"taxi/uservices/userver/core/src/components/process_starter.cpp",
   "core/src/components/process_starter.yaml":"taxi/uservices/userver/core/src/components/process_starter.yaml",
-  "core/src/components/resource_scope_test.cpp":"taxi/uservices/userver/core/src/components/resource_scope_test.cpp",
   "core/src/components/run.cpp":"taxi/uservices/userver/core/src/components/run.cpp",
+  "core/src/components/scope_test.cpp":"taxi/uservices/userver/core/src/components/scope_test.cpp",
   "core/src/components/single_threaded_task_processors.cpp":"taxi/uservices/userver/core/src/components/single_threaded_task_processors.cpp",
   "core/src/components/single_threaded_task_processors.yaml":"taxi/uservices/userver/core/src/components/single_threaded_task_processors.yaml",
   "core/src/components/state.cpp":"taxi/uservices/userver/core/src/components/state.cpp",

core/src/components/component_lifecycle_test.cpp

@@ -0,0 +1,87 @@
+#include <gtest/gtest.h>
+
+#include <userver/components/component_base.hpp>
+#include <userver/components/component_context.hpp>
+#include <userver/components/minimal_component_list.hpp>
+#include <userver/components/run.hpp>
+
+#include <components/component_list_test.hpp>
+
+USERVER_NAMESPACE_BEGIN
+
+namespace {
+
+std::atomic<bool> good_component_constructed{false};
+std::atomic<bool> good_component_on_all_components_loaded_called{false};
+std::atomic<bool> good_component_on_all_components_stopping_called{false};
+std::atomic<bool> bad_component_construction_started{false};
+
+class GoodComponent final : public components::ComponentBase {
+public:
+    static constexpr std::string_view kName = "good-component";
+
+    GoodComponent(const components::ComponentConfig& config, const components::ComponentContext& context)
+        : ComponentBase(config, context)
+    {
+        good_component_constructed = true;
+    }
+
+    void OnAllComponentsLoaded() override { good_component_on_all_components_loaded_called = true; }
+
+    void OnAllComponentsAreStopping() override { good_component_on_all_components_stopping_called = true; }
+};
+
+class BadComponent final : public components::ComponentBase {
+public:
+    static constexpr std::string_view kName = "bad-component";
+
+    BadComponent(const components::ComponentConfig& config, const components::ComponentContext& context)
+        : ComponentBase(config, context)
+    {
+        [[maybe_unused]] auto& good_component = context.FindComponent<GoodComponent>();
+        bad_component_construction_started = true;
+        throw std::runtime_error("BadComponent constructor intentionally throws");
+    }
+};
+
+}  // namespace
+
+TEST(ComponentLifecycle, OnAllComponentsAreStoppingCalledWhenConstructorThrows) {
+    // Reset static variables for --gtest_repeat.
+    good_component_constructed = false;
+    good_component_on_all_components_loaded_called = false;
+    good_component_on_all_components_stopping_called = false;
+    bad_component_construction_started = false;
+
+    const std::string config = tests::MergeYaml(
+        tests::kMinimalStaticConfig,
+        R"(
+components_manager:
+    components:
+        logging:
+            fs-task-processor: main-task-processor
+            loggers:
+                default:
+                    file_path: '@null'
+                    format: ltsv
+        good-component: {}
+        bad-component: {}
+)"
+    );
+
+    UEXPECT_THROW_MSG(
+        components::RunOnce(
+            components::InMemoryConfig{config},
+            components::MinimalComponentList().Append<GoodComponent>().Append<BadComponent>()
+        ),
+        std::runtime_error,
+        "BadComponent constructor intentionally throws"
+    );
+
+    EXPECT_TRUE(good_component_constructed);
+    EXPECT_TRUE(bad_component_construction_started);
+    EXPECT_FALSE(good_component_on_all_components_loaded_called);
+    EXPECT_TRUE(good_component_on_all_components_stopping_called);
+}
+
+USERVER_NAMESPACE_END

…e/src/components/resource_scope_test.cpp core/src/components/scope_test.cppcore/src/components/resource_scope_test.cpp renamed to core/src/components/scope_test.cpp core/src/components/resource_scope_test.cpp renamed to core/src/components/scope_test.cpp

@@ -1,11 +1,12 @@
-#include <userver/utest/utest.hpp>
+#include <gmock/gmock.h>
 
 #include <userver/components/component_base.hpp>
 #include <userver/components/component_context.hpp>
 #include <userver/components/minimal_component_list.hpp>
 #include <userver/components/run.hpp>
 #include <userver/components/scope.hpp>
 #include <userver/logging/log.hpp>
+#include <userver/utest/utest.hpp>
 #include <userver/utils/fast_scope_guard.hpp>
 
 USERVER_NAMESPACE_BEGIN
@@ -34,8 +35,12 @@ const std::string kConfig = R"(
 
 TEST(ComponentsScope, Smoke)
 {
-    static bool init_called = false;
-    static bool destroy_called = false;
+    static bool init_called{};
+    static bool destroy_called{};
+
+    // Reset static variables for --gtest_repeat.
+    init_called = false;
+    destroy_called = false;
 
     class ComponentWithResource final : public components::ComponentBase {
     public:
@@ -60,6 +65,9 @@ TEST(ComponentsScope, HappyPathOrder)
 {
     static std::vector<int> trace;
 
+    // Reset static variables for --gtest_repeat.
+    trace = {};
+
     class ComponentWithResource final : public components::ComponentBase {
     public:
         ComponentWithResource(const components::ComponentConfig& config, const components::ComponentContext& context)
@@ -82,13 +90,16 @@ TEST(ComponentsScope, HappyPathOrder)
     auto component_list = components::MinimalComponentList().Append<ComponentWithResource>("component");
     components::RunOnce(components::InMemoryConfig{kConfig}, component_list);
 
-    EXPECT_EQ(trace, (std::vector{0, 1, 3, 4, 2}));
+    EXPECT_THAT(trace, ::testing::ElementsAre(0, 1, 3, 4, 2));
 }
 
 TEST(ComponentsScope, CtrThrow)
 {
     static std::vector<int> trace;
 
+    // Reset static variables for --gtest_repeat.
+    trace = {};
+
     class ComponentWithResource final : public components::ComponentBase {
     public:
         ComponentWithResource(const components::ComponentConfig& config, const components::ComponentContext& context)
@@ -111,15 +122,22 @@ TEST(ComponentsScope, CtrThrow)
     };
 
     auto component_list = components::MinimalComponentList().Append<ComponentWithResource>("component");
-    EXPECT_THROW(components::RunOnce(components::InMemoryConfig{kConfig}, component_list), std::runtime_error);
+    UEXPECT_THROW_MSG(
+        components::RunOnce(components::InMemoryConfig{kConfig}, component_list),
+        std::runtime_error,
+        "1"
+    );
 
-    EXPECT_EQ(trace, (std::vector{0}));
+    EXPECT_THAT(trace, ::testing::ElementsAre(0));
 }
 
 TEST(ComponentsScope, CallbackThrow)
 {
     static std::vector<int> trace;
 
+    // Reset static variables for --gtest_repeat.
+    trace = {};
+
     class ComponentWithResource final : public components::ComponentBase {
     public:
         ComponentWithResource(const components::ComponentConfig& config, const components::ComponentContext& context)
@@ -141,9 +159,13 @@ TEST(ComponentsScope, CallbackThrow)
     };
 
     auto component_list = components::MinimalComponentList().Append<ComponentWithResource>("component");
-    EXPECT_THROW(components::RunOnce(components::InMemoryConfig{kConfig}, component_list), std::runtime_error);
+    UEXPECT_THROW_MSG(
+        components::RunOnce(components::InMemoryConfig{kConfig}, component_list),
+        std::runtime_error,
+        "1"
+    );
 
-    EXPECT_EQ(trace, (std::vector{0, 1, 3, 2}));
+    EXPECT_THAT(trace, ::testing::ElementsAre(0, 1, 3, 2));
 }
 
 USERVER_NAMESPACE_END